FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-139400: Make sure that parent parsers outlive their subparsers in `pyexpat` (GH-139403) by hartwork · Pull Request #139609 · python/cpython · GitHub

/ cpython Public

[3.12] gh-139400: Make sure that parent parsers outlive their subparsers in pyexpat (GH-139403) - #139609

Merged
ambv merged 2 commits into
python:3.12from
hartwork:backport-6edb2dd-3.12
Oct 7, 2025
ConversationCommits (2)ChecksFiles changed
Merged

[3.12] gh-139400: Make sure that parent parsers outlive their subparsers in pyexpat (GH-139403)#139609
ambv merged 2 commits into
python:3.12from
hartwork:backport-6edb2dd-3.12

Conversation

hartwork commented Oct 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

pythongh-139400: Make sure that parent parsers outlive their subparse…
65730f3 
…rs in `pyexpat` (python#139403)

* Modules/pyexpat.c: Disallow collection of in-use parent parsers.

Within libexpat, a parser created via `XML_ExternalEntityParserCreate`
is relying on its parent parser throughout its entire lifetime.
Prior to this fix, is was possible for the parent parser to be
garbage-collected too early.

(cherry picked from commit 6edb2dd)
This was referenced Oct 5, 2025
Closed
Merged
hartwork changed the title [3.12] gh-139400: Make sure that parent parsers outlive their subparsers in pyexpat (GH-139403) [3.12] gh-139400: Make sure that parent parsers outlive their subparsers in pyexpat (GH-139403) Oct 5, 2025
picnixz assigned pablogsal and Yhg1s and unassigned pablogsal Oct 6, 2025

picnixz commented Oct 6, 2025

Copy link
Copy Markdown
Member

(Sorry for the misassignments; I got lost in my multiple tabs & backport versions :))

ambv merged commit dea7e3d into python:3.12 Oct 7, 2025
28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
picnixz picnixz approved these changes

Assignees

Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL