FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-139736: Fix argparse indentation overshoot by 9001 · Pull Request #139738 · python/cpython · GitHub

/ cpython Public

gh-139736: Fix argparse indentation overshoot - #139738

Merged
savannahostrowski merged 2 commits into
python:mainfrom
9001:argparse-indent-fix
Oct 8, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-139736: Fix argparse indentation overshoot#139738
savannahostrowski merged 2 commits into
python:mainfrom
9001:argparse-indent-fix

Conversation

9001 commented Oct 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

When calculating the --help indentation, strip colors before counting the action length.

python-cla-bot Bot commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Oct 7, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Oct 7, 2025
Closed

9001 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

The argparse tests failed because the previous indentation amount is expected; should I go over the tests and adjust them accordingly?

pythongh-139736: Fix argparse indentation overshoot
f63fed7 
When calculating the --help indentation,
strip colors before counting the action length
9001 force-pushed the argparse-indent-fix branch from 2ac39cb to f63fed7 Compare October 8, 2025 00:07

savannahostrowski commented Oct 8, 2025

Copy link
Copy Markdown
Member

@9001 Thanks for catching this. I was able to reproduce this, and it appears that those tests were introduced in #133941, following the change in spacing with #130645. So yeah, I think we can update the tests to reflect the correct spacing.

hugovk added the needs backport to 3.14 bugs and security fixes label Oct 8, 2025

9001 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Alright -- I believe the remaining test failure is unrelated. Please let me know if there is anything more to be done at this point :)

hugovk commented Oct 8, 2025

Copy link
Copy Markdown
Member

I restarted the failure and it passed 👍

savannahostrowski approved these changes Oct 8, 2025
View reviewed changes

savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks so much!

savannahostrowski enabled auto-merge (squash) October 8, 2025 15:09
savannahostrowski merged commit 72e370c into python:main Oct 8, 2025
45 checks passed

miss-islington-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

Thanks @9001 for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
pythongh-139736: Fix argparse indentation overshoot (pythonGH-139738)
a4e04b7 
(cherry picked from commit 72e370c)

Co-authored-by: ed <s@ocv.me>
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139793 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
savannahostrowski added a commit that referenced this pull request Oct 8, 2025
[3.14] gh-139736: Fix argparse indentation overshoot (GH-139738) (#13…
14c923c 
…9793)

gh-139736: Fix argparse indentation overshoot (GH-139738)
(cherry picked from commit 72e370c)

Co-authored-by: ed <s@ocv.me>
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

savannahostrowski savannahostrowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL