gh-140438: Properly run the asyncio REPL in REPL tests by johnslavik · Pull Request #140298 · python/cpython · GitHub

Mixing -i with -m asyncio first spawns the asyncio REPL. After asyncio REPL exits, it spawns the regular Python REPL.

Here we're introducing more idiomatic way to test other custom REPLs in test_repl as necessary, without needing a pseudo-terminal.

CC @ZeroIntensity (mentorship): skip issue, skip news, needs backport to 3.13, needs backport to 3.14.

Issue: The -i flag is mixed with custom REPLs in tests #140438

I think it would be good if you created an issue for this.

I think it would be good if you created an issue for this.

@ZeroIntensity done; let's remove the skip issue label now so that the bot can do its job.

cc @asvetlov

@kumaraditya303 is our primary asyncio maintainer at the moment. Kumar, are you familiar enough with the asyncio REPL to review this?

LGTM

Thanks @bswck for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

GH-140507 is a backport of this pull request to the 3.14 branch.

GH-140508 is a backport of this pull request to the 3.13 branch.

…40508) gh-140438: properly run the asyncio REPL tests (GH-140298) (cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

…40507) gh-140438: properly run the asyncio REPL tests (GH-140298) (cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit adf0c11.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1697) and take a look at the build logs.
Check if the failure is related to this commit (adf0c11) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1697

Failed tests:

test.test_multiprocessing_forkserver.test_processes

Failed subtests:

test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1492, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

Properly run asyncio REPL in REPL tests

e396622

bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Oct 18, 2025

Move comment to a better place

4079074

johnslavik mentioned this pull request Oct 18, 2025

test_repl.test_toplevel_contextvars_async fails under Fish in a VS Code terminal #137569

Closed

ZeroIntensity added skip issue skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 18, 2025

johnslavik mentioned this pull request Oct 21, 2025

The -i flag is mixed with custom REPLs in tests #140438

Closed

johnslavik changed the title Properly run the asyncio REPL in REPL tests gh-140438: Properly run the asyncio REPL in REPL tests Oct 21, 2025

ZeroIntensity removed the skip issue label Oct 21, 2025

kumaraditya303 approved these changes Oct 23, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 23, 2025

johnslavik mentioned this pull request Oct 23, 2025

gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL #140288

Merged

kumaraditya303 merged commit 1a3da2c into python:main Oct 23, 2025
57 checks passed

bedevere-app Bot removed the awaiting merge label Oct 23, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2025

pythongh-140438 : properly run the asyncio REPL tests (pythonGH-140298 )

9117c34

(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2025

pythongh-140438 : properly run the asyncio REPL tests (pythonGH-140298 )

d21158a

(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 23, 2025

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 23, 2025

johnslavik deleted the properly-run-asyncio-repl-in-repl-tests branch December 2, 2025 00:44

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025

pythongh-140438 : properly run the asyncio REPL tests (python#140298 )

0491b53

gh-140438: Properly run the asyncio REPL in REPL tests by johnslavik · Pull Request #140298 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-140438: Properly run the asyncio REPL in REPL tests - #140298

gh-140438: Properly run the asyncio REPL in REPL tests#140298
kumaraditya303 merged 2 commits into
python:mainfrom
johnslavik:properly-run-asyncio-repl-in-repl-tests

johnslavik commented Oct 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

Uh oh!

ZeroIntensity commented Oct 18, 2025

Uh oh!

johnslavik commented Oct 21, 2025

Uh oh!

johnslavik commented Oct 23, 2025

Uh oh!

ZeroIntensity commented Oct 23, 2025

Uh oh!

kumaraditya303 left a comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 23, 2025

Uh oh!

bedevere-app Bot commented Oct 23, 2025

Uh oh!

bedevere-app Bot commented Oct 23, 2025

Uh oh!

bedevere-bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-140438: Properly run the asyncio REPL in REPL tests by johnslavik · Pull Request #140298 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-140438: Properly run the asyncio REPL in REPL tests - #140298

gh-140438: Properly run the asyncio REPL in REPL tests#140298kumaraditya303 merged 2 commits intopython:mainpython/cpython:mainfrom johnslavik:properly-run-asyncio-repl-in-repl-testsjohnslavik/cpython:properly-run-asyncio-repl-in-repl-testsCopy head branch name to clipboard

Conversation

johnslavik commented Oct 18, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity commented Oct 18, 2025

Uh oh!

johnslavik commented Oct 21, 2025

Uh oh!

johnslavik commented Oct 23, 2025

Uh oh!

ZeroIntensity commented Oct 23, 2025

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 23, 2025

Uh oh!

bedevere-app Bot commented Oct 23, 2025

Uh oh!

bedevere-app Bot commented Oct 23, 2025

Uh oh!

bedevere-bot commented Oct 23, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-140438: Properly run the asyncio REPL in REPL tests#140298
kumaraditya303 merged 2 commits into
python:mainfrom
johnslavik:properly-run-asyncio-repl-in-repl-tests

johnslavik commented Oct 18, 2025 •
edited by bedevere-app Bot
Loading