Repository navigation
gh-76007: Deprecate __version__ attribute in imaplib - #140299
Merged
hugovk merged 2 commits intoOct 20, 2025
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
johnslavik
approved these changes
Oct 18, 2025
Copy link
Copy Markdown
Member
|
I think it is fine to remove it. We anyway have a divergence between 3.13 and 3.14 because 3.14 had a new feature and 3.13 and 3.14 had bugfixes that I addes, so it would only help if we had both the version of Python and the IMAP one. IMO such debugging information could only be useful if the Python version also included the git commit it is based on but that would be an overkill I think. |
Sorry, something went wrong.
vstinner
reviewed
Oct 18, 2025
Comment thread
Lib/imaplib.py
Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
approved these changes
Oct 20, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…n#140299) Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove it from the debug output:
if __debug__: self._cmd_log_len = 10 self._cmd_log_idx = 0 self._cmd_log = {} # Last '_cmd_log_len' interactions if self.debug >= 1: - self._mesg('imaplib version %s' % __version__) self._mesg('new IMAP4 connection, tag=%s' % self.tagpre)@picnixz Or would you prefer to put the Python version here?
📚 Documentation preview 📚: https://cpython-previews--140299.org.readthedocs.build/