| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Could you create a new issue for this, and tag people interested in AC? |
Sorry, something went wrong.
|
I can create a new issue, but all CODEOWNERs have already been notified. Do you have anyone else in mind? |
Sorry, something went wrong.
There was a problem hiding this comment.
Wouldn't it make more sense to just support arbitrary dunder methods? __getattr__ isn't very common in C code, among other things.
Sorry, something went wrong.
|
I'm also not convinced this is worth it. __getattr__() really ought to be implemented at the Python level, modules implemented entirely in C (like zlib) are very much a special case, and aren't used for new stdlib modules. A |
Sorry, something went wrong.
|
On the other hand, I would be very supportive of allowing arbitrary dunders in AC, though I suspect that would be a lot of extra work (because we would need to map dunders to PyTypeObject fields). |
Sorry, something went wrong.
No, it’s just the general principle that «should we do?» discussions happen in issues (and when needed on the forums), then the PR can host «how to do?» discussions. |
Sorry, something went wrong.
There was a problem hiding this comment.
Wouldn't it make more sense to just support arbitrary dunder methods?
I think it's ok to add support of specific dunders on-demand. It's not too helpful in general, because sometimes we can do too much with slots, even override the docstring.
But please think about more generic case. For example, for most dunders we have very specific function signatures. It will be redundant and error-prone to specify this stuff by hand.
Sorry, something went wrong.
I would prefer to only add support when it will really be needed, so we can test on actual code rather than unit tests. In short, I'm supportive of only adding support for __getattr__() for now. |
Sorry, something went wrong.
|
I don't think that will work well in practice. Judging by this PR, adding support for a new dunder method seems non-trivial. People will probably decide to just write things the old way instead of updating clinic, which we don't want. |
Sorry, something went wrong.
|
Closing, there is little need and support for this. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.