FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-139707: Specify `winreg`, `msvcrt` and `winsound` module availability in docs by StanFromIreland · Pull Request #140429 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-139707: Specify winreg, msvcrt and winsound module availability in docs - #140429

Merged
encukou merged 2 commits into
python:mainfrom
StanFromIreland:winreg
Nov 10, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-139707: Specify winreg, msvcrt and winsound module availability in docs#140429
encukou merged 2 commits into
python:mainfrom
StanFromIreland:winreg

Conversation

StanFromIreland commented Oct 21, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 21, 2025
github-project-automation Bot moved this to Todo in Docs PRs Oct 21, 2025
StanFromIreland changed the title Specify winreg availability in docs Specify winreg module availability in docs Oct 21, 2025

StanFromIreland commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

There are a few more cases, I will add them to this PR.

StanFromIreland marked this pull request as draft October 21, 2025 16:10
StanFromIreland marked this pull request as ready for review October 21, 2025 16:13
StanFromIreland changed the title Specify winreg module availability in docs Specify winreg, msvcrt and winsound module availability in docs Oct 21, 2025
StanFromIreland changed the title Specify winreg, msvcrt and winsound module availability in docs gh-139707: Specify winreg, msvcrt and winsound module availability in docs Oct 21, 2025

encukou commented Nov 7, 2025

Copy link
Copy Markdown
Member

Hmm, I see these all have :platform: Windows in the header. That's a standard Sphinx option but that seems to have no effect since Sphinx 1.1.
Should we remove that or keep it maintained (everywhere)?

StanFromIreland commented Nov 7, 2025

Copy link
Copy Markdown
Member Author

Should we remove that or keep it maintained (everywhere)?

In my opinion, keeping the existing ones doesn’t have any significant impact, on the other hand, removing them is the same. I don't see any reason to add more. As such, I'm 0 on changing anything with them, although I don't mind removing them all (for consistency, it makes little sense to remove just the three) in this PR either, if you so wish.

encukou commented Nov 10, 2025

Copy link
Copy Markdown
Member

I guess that if we do remove them, it should be its own PR.

encukou merged commit 13fa313 into python:main Nov 10, 2025
33 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 10, 2025
encukou added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025

miss-islington-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
672471e 
…ilability in docs (pythonGH-140429)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141350 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
7cb6cf5 
…ilability in docs (pythonGH-140429)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141351 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
encukou pushed a commit that referenced this pull request Nov 10, 2025
[3.14] gh-139707: Specify winreg, msvcrt and winsound module av…
63a3737 
…ailability in docs (GH-140429) (GH-141351)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Nov 10, 2025
[3.13] gh-139707: Specify winreg, msvcrt and winsound module av…
1f9f8e5 
…ailability in docs (GH-140429) (GH-141350)

(cherry picked from commit 13fa313)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
encukou mentioned this pull request Nov 11, 2025
Closed
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-139707: Specify winreg, msvcrt and winsound module ava…
5a5b0c6 
…ilability in docs (pythonGH-140429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aisk aisk approved these changes
encukou Awaiting requested review from encukou
zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL