gh-135676: Simplify docs on lexing names - #140464
Merged
encukou merged 8 commits intoNov 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Micha Albert <info@micha.zone> Co-authored-by: KeithTheEE <kmurrayis@gmail.com>
willingc
approved these changes
Oct 22, 2025
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
| This means that, for example, some typographic variants of characters are | ||
| converted to their "basic" form, for example:: | ||
|
|
||
| >>> nᵘₘᵇₑʳ = 3 |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It would be helpful to add an explicit comment that the normalized form of nᵘₘᵇₑʳis number.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Does this look good?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
There was an insightful conversation in #140269. I'll update this PR to make things even clearer. |
Sorry, something went wrong.
willingc
approved these changes
Nov 10, 2025
encukou
marked this pull request as ready for review
November 19, 2025 16:08
willingc
approved these changes
Nov 19, 2025
Copy link
Copy Markdown
Member
Author
|
Thank you for the review! @malemburg, do you also want to take a look? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 2ff8608b4da33f667960e5099a1a442197acaea4 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-142015 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Nov 27, 2025
This simplifies the Lexical Analysis section on Names (but keeps it technically correct) by putting all the info about non-ASCII characters in a separate (and very technical) section. It uses a mental model where the parser doesn't handle Unicode complexity “immediately”, but: - parses any non-ASCII character (outside strings/comments) as part of a name, since these can't (yet) be e.g. operators - normalizes the name - validates the name, using the xid_start/xid_continue sets (cherry picked from commit 2ff8608) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Micha Albert <info@micha.zone> Co-authored-by: KeithTheEE <kmurrayis@gmail.com>
encukou
added a commit
that referenced
this pull request
Dec 3, 2025
This simplifies the Lexical Analysis section on Names (but keeps it technically correct) by putting all the info about non-ASCII characters in a separate (and very technical) section. It uses a mental model where the parser doesn't handle Unicode complexity “immediately”, but: - parses any non-ASCII character (outside strings/comments) as part of a name, since these can't (yet) be e.g. operators - normalizes the name - validates the name, using the xid_start/xid_continue sets (cherry picked from commit 2ff8608) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Micha Albert <info@micha.zone> Co-authored-by: KeithTheEE <kmurrayis@gmail.com>
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This simplifies the Lexical Analysis section on Names (but keeps it technically correct) by putting all the info about non-ASCII characters in a separate (and very technical) section. It uses a mental model where the parser doesn't handle Unicode complexity “immediately”, but: - parses any non-ASCII character (outside strings/comments) as part of a name, since these can't (yet) be e.g. operators - normalizes the name - validates the name, using the xid_start/xid_continue sets Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Micha Albert <info@micha.zone> Co-authored-by: KeithTheEE <kmurrayis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the Lexical Analysis section on Names (but keeps it technically correct) by putting all the info about non-ASCII characters in a separate (and very technical) section.
It uses a mental model where the parser doesn't handle Unicode complexity “immediately”, but:
This also means we don't need xid_start/xid_continue to define the behaviour :)
📚 Documentation preview 📚: https://cpython-previews--140464.org.readthedocs.build/