Repository navigation
gh-140790: pdb: Initialize instance variables in Pdb.__init__ - #140791
Merged
gaogaotiantian merged 4 commits intoNov 14, 2025
Merged
gaogaotiantian merged 4 commits into
gaogaotiantian merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Carreau
commented
Oct 31, 2025
Comment thread
Lib/pdb.py
Outdated
Carreau
commented
Oct 31, 2025
Comment thread
Lib/pdb.py
Outdated
Initialize lineno, stack, curindex, curframe, currentbp, and _user_requested_quit attributes in `Pdb.__init__`` instead of at first use. This ensures these attributes are always defined and allows removal of defensive getattr/hasattr checks throughout the codebase. In particular for a custom PDB subclass in IPython, the need to use a getattr has performance implications, and while we could set it our `__init__` it was easy to send a more global patch to CPython. Should fix pythongh-140790
gaogaotiantian
approved these changes
Nov 14, 2025
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit 4885ecf. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1610/builds/2417 Failed tests:
Test leaking resources:
Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 9, done.
remote: Counting objects: 12% (1/8)
remote: Counting objects: 25% (2/8)
remote: Counting objects: 37% (3/8)
remote: Counting objects: 50% (4/8)
remote: Counting objects: 62% (5/8)
remote: Counting objects: 75% (6/8)
remote: Counting objects: 87% (7/8)
remote: Counting objects: 100% (8/8)
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 12% (1/8)
remote: Compressing objects: 25% (2/8)
remote: Compressing objects: 37% (3/8)
remote: Compressing objects: 50% (4/8)
remote: Compressing objects: 62% (5/8)
remote: Compressing objects: 75% (6/8)
remote: Compressing objects: 87% (7/8)
remote: Compressing objects: 100% (8/8)
remote: Compressing objects: 100% (8/8), done.
remote: Total 9 (delta 0), reused 0 (delta 0), pack-reused 1 (from 1)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '4885ecfbda4cc792691e5d488ef6cb09727eb417'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 4885ecfbda4 gh-140790: pdb: Initialize instance variables in Pdb.__init__ (#140791)
Switched to and reset branch 'main'
configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module
make: *** [Makefile:2493: buildbottest] Error 2 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The buildbot alert seems to be irrelevant. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for the review and the merge! |
Sorry, something went wrong.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ython#140791) Initialize lineno, stack, curindex, curframe, currentbp, and _user_requested_quit attributes in `Pdb.__init__``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize lineno, stack, curindex, curframe,
currentbp, and _user_requested_quit attributes in
Pdb.__init__ instead of at first use. This ensures these attributes are always defined and allows
removal of defensive getattr/hasattr checks
throughout the codebase.
In particular for a custom PDB subclass in
IPython, the need to use a getattr has performance implications, and while we could set it our __init__ it was easy to send a more global patch to CPython.
Should fix gh-140790