FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103847: fix cancellation safety of `asyncio.create_subprocess_exec` by kumaraditya303 · Pull Request #140805 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-103847: fix cancellation safety of asyncio.create_subprocess_exec - #140805

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:asyncio-subprocess-cancellation
Nov 12, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-103847: fix cancellation safety of asyncio.create_subprocess_exec#140805
kumaraditya303 merged 6 commits into
python:mainfrom
kumaraditya303:asyncio-subprocess-cancellation

Conversation

kumaraditya303 commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes the cancellation safety of asyncio.create_subprocess_exec. This is the simplest change I can think of which fixes the issue and is small enough that it can backported as well. A larger change would be rewrite some part of _UnixSubprocessTransport to make it cancellation safe but that would be a much larger change that I would be comfortable doing for 3.15 only.

I plan to add some tests by end of week.

bedevere-app Bot mentioned this pull request Oct 30, 2025
Closed
kumaraditya303 marked this pull request as ready for review October 30, 2025 17:39
kumaraditya303 force-pushed the asyncio-subprocess-cancellation branch from f79799a to c8c31fd Compare October 31, 2025 06:56
kumaraditya303 force-pushed the asyncio-subprocess-cancellation branch from 7d3858a to 12cd899 Compare October 31, 2025 12:55

kumaraditya303 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

I have added three tests all of which hang on main branch without this PR and manually tested that it fixes reproducers on the issue as well.

kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 1, 2025

bedevere-bot commented Nov 1, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 56beaf2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140805%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 1, 2025
gvanrossum requested a review from graingert November 6, 2025 03:35
kumaraditya303 merged commit ef474cf into python:main Nov 12, 2025
46 checks passed

miss-islington-app Bot commented Nov 12, 2025

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
pythongh-103847: fix cancellation safety of `asyncio.create_subproces…
3d41392 
…s_exec` (pythonGH-140805)

(cherry picked from commit ef474cf)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>

bedevere-app Bot commented Nov 12, 2025

Copy link
Copy Markdown

GH-141446 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
pythongh-103847: fix cancellation safety of `asyncio.create_subproces…
01a46e9 
…s_exec` (pythonGH-140805)

(cherry picked from commit ef474cf)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>

bedevere-app Bot commented Nov 12, 2025

Copy link
Copy Markdown

GH-141447 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 12, 2025
kumaraditya303 deleted the asyncio-subprocess-cancellation branch November 12, 2025 05:17
kumaraditya303 added a commit that referenced this pull request Nov 13, 2025
[3.14] gh-103847: fix cancellation safety of `asyncio.create_subproce…
7e9400c 
…ss_exec` (GH-140805) (#141446)

gh-103847: fix cancellation safety of `asyncio.create_subprocess_exec` (GH-140805)
(cherry picked from commit ef474cf)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Nov 13, 2025
[3.13] gh-103847: fix cancellation safety of `asyncio.create_subproce…
e5b82c4 
…ss_exec` (GH-140805) (#141447)

gh-103847: fix cancellation safety of `asyncio.create_subprocess_exec` (GH-140805)
(cherry picked from commit ef474cf)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-103847: fix cancellation safety of `asyncio.create_subproces…
3bf8038 
…s_exec` (python#140805)
fantix mentioned this pull request Jan 11, 2026
Closed
daandemeyer mentioned this pull request Mar 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
gvanrossum Awaiting requested review from gvanrossum
graingert Awaiting requested review from graingert

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL