Repository navigation
gh-37883: Fix test_resource failures with file size limits - #140872
ritesh006 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…limits This fixes the long-standing issue where test_resource would fail on systems with file size limitations. The solution includes: - ResourceLimitHelper class for safe limit manipulation - Dynamic test sizing based on available resources - Conditional test skipping with clear messages - Comprehensive error handling for various platforms Tests now adapt to system constraints rather than failing. Fixes python#37883
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
There was a problem hiding this comment.
Please revert all unrelated changes. Do not add docstrings to test methods because they will be rendered on failures. Do not change the skipIf/skipUnless, they are irrelevant and reduce the diff readability. Focus on fixing the tests themselves, but not refactoring the existing code (if this is needed, this must be done in a separate PR).
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
The referenced issue has been addressed by a different PR; closing. |
Sorry, something went wrong.
This fixes the long-standing issue where test_resource would fail on systems with file size limitations. The solution includes:
Tests now adapt to system constraints rather than failing.
Fixes #37883