FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: Document `PyFunction_SetKwDefaults` by ZeroIntensity · Pull Request #141294 · python/cpython · GitHub

/ cpython Public

gh-141004: Document PyFunction_SetKwDefaults - #141294

Merged
ZeroIntensity merged 2 commits into
python:mainfrom
ZeroIntensity:document-set-kw-defaults
Nov 9, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-141004: Document PyFunction_SetKwDefaults#141294
ZeroIntensity merged 2 commits into
python:mainfrom
ZeroIntensity:document-set-kw-defaults

Conversation

ZeroIntensity commented Nov 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 9, 2025
bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 9, 2025
github-project-automation Bot moved this to Todo in Docs PRs Nov 9, 2025
bedevere-app Bot mentioned this pull request Nov 9, 2025
Open
StanFromIreland reviewed Nov 9, 2025
View reviewed changes
Comment thread Doc/c-api/function.rst Outdated
Comment thread Doc/c-api/function.rst
Comment thread Doc/c-api/function.rst
StanFromIreland reviewed Nov 9, 2025
View reviewed changes
Comment thread Doc/c-api/function.rst
Comment on lines +107 to +108
Set the keyword-only argument default values of the function object *op*.
*defaults* must be a dictionary of keyword-only arguments or ``Py_None``.

StanFromIreland Nov 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Set the keyword-only argument default values of the function object *op*.
*defaults* must be a dictionary of keyword-only arguments or ``Py_None``.
Set the keyword-only parameter default values of the function object *op*.
*defaults* must be a dictionary of keyword-only parameters or ``Py_None``.

ZeroIntensity Nov 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We say "argument" everywhere else in this file, so I'd rather not deviate from it here. I don't think that the distinction is particularly helpful for readers here.

StanFromIreland Nov 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not a fan of such a precedent, but unfortunately it is. Fixing this is tracked in #133438.

StanFromIreland approved these changes Nov 9, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity merged commit 18529b5 into python:main Nov 9, 2025
28 checks passed
ZeroIntensity deleted the document-set-kw-defaults branch November 9, 2025 17:49
github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 9, 2025

miss-islington-app Bot commented Nov 9, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
pythongh-141004: Document PyFunction_SetKwDefaults (pythonGH-141294)
cd60b7d 
(cherry picked from commit 18529b5)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app Bot commented Nov 9, 2025

Copy link
Copy Markdown

GH-141304 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
pythongh-141004: Document PyFunction_SetKwDefaults (pythonGH-141294)
502fdd1 
(cherry picked from commit 18529b5)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app Bot commented Nov 9, 2025

Copy link
Copy Markdown

GH-141305 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 9, 2025
ZeroIntensity added a commit that referenced this pull request Nov 9, 2025
[3.13] gh-141004: Document PyFunction_SetKwDefaults (GH-141294) (GH…
aa2c8ea 
…-141305)

gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294)
(cherry picked from commit 18529b5)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity added a commit that referenced this pull request Nov 9, 2025
[3.14] gh-141004: Document PyFunction_SetKwDefaults (GH-141294) (GH…
8682465 
…-141304)

gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294)
(cherry picked from commit 18529b5)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: Document PyFunction_SetKwDefaults (pythonGH-141294)
e0053e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL