Repository navigation
gh-141376: Fix exported symbols - #141377
Merged
encukou merged 2 commits intoNov 11, 2025
Merged
encukou merged 2 commits into
encukou merged 2 commits into
Conversation
* _io module: add "_Py_" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec. * typevarobject.c: add "static" to "spec" and "slots" variables. * import.c: add "static" to "pkgcontext" variable.
vstinner
requested review from
JelleZijlstra,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
November 10, 2025 21:03
Copy link
Copy Markdown
Member
Author
|
With this patch: diff --git a/Tools/build/smelly.py b/Tools/build/smelly.py
index 9a360412a73..0b694392583 100755
--- a/Tools/build/smelly.py
+++ b/Tools/build/smelly.py
@@ -37,7 +37,7 @@ def is_local_symbol_type(symtype):
# Ignore the initialized data section (d and D) and the BSS data
# section. For example, ignore "__bss_start (type: B)"
# and "_edata (type: D)".
- if symtype in "bBdD":
+ if symtype in "bB":
return True
return Falsemake smelly detects fixed export issues, but also this symbol: + nm --no-sort libpython3.15d.a Ignore 15820 local symbols Smelly symbol: _AsyncioDebug (type: D) ERROR: Found 1 smelly symbols! |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Nov 10, 2025
cmaloney
approved these changes
Nov 10, 2025
cmaloney
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Most modules don't need the extern PyType_Spec pieces that the _io module currently uses; 👍 for this change and I added to my I/O rework notes that it would be nice to reduce the need for these.
Sorry, something went wrong.
gpshead
approved these changes
Nov 11, 2025
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commit 8435a22. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1610/builds/2396 Failed tests:
Test leaking resources:
Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 17, done.
remote: Counting objects: 6% (1/16)
remote: Counting objects: 12% (2/16)
remote: Counting objects: 18% (3/16)
remote: Counting objects: 25% (4/16)
remote: Counting objects: 31% (5/16)
remote: Counting objects: 37% (6/16)
remote: Counting objects: 43% (7/16)
remote: Counting objects: 50% (8/16)
remote: Counting objects: 56% (9/16)
remote: Counting objects: 62% (10/16)
remote: Counting objects: 68% (11/16)
remote: Counting objects: 75% (12/16)
remote: Counting objects: 81% (13/16)
remote: Counting objects: 87% (14/16)
remote: Counting objects: 93% (15/16)
remote: Counting objects: 100% (16/16)
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 33% (1/3)
remote: Compressing objects: 66% (2/3)
remote: Compressing objects: 100% (3/3)
remote: Compressing objects: 100% (3/3), done.
remote: Total 17 (delta 13), reused 13 (delta 13), pack-reused 1 (from 1)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '8435a2278f964f48d36edbc5092be5ebecfcb120'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 8435a2278f9 gh-141376: Fix exported symbols (GH-141377)
Switched to and reset branch 'main'
configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module
make: *** [Makefile:2493: buildbottest] Error 2 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
(The noGIL failure is a known issue, #120158.) |
Sorry, something went wrong.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
* pythongh-141376: Fix exported symbols * _io module: add "_Py_" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec. * typevarobject.c: add "static" to "spec" and "slots" variables. * import.c: add "static" to "pkgcontext" variable. * No longer export textiowrapper_slots
Comment thread
Python/import.c
| */ | ||
|
|
||
| _Py_thread_local const char *pkgcontext = NULL; | ||
| static _Py_thread_local const char *pkgcontext = NULL; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This particular change is quite annoying for Nuitka. We need access to this for our importer to work. Let's either re-expose this or add an unstable API for it (see #139227).
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.