FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` by ZeroIntensity · Pull Request #141413 · python/cpython · GitHub

/ cpython Public

gh-141004: Document PyFile_OpenCode and PyFile_OpenCodeObject - #141413

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:document-pyfile
Nov 11, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-141004: Document PyFile_OpenCode and PyFile_OpenCodeObject#141413
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:document-pyfile

Conversation

ZeroIntensity commented Nov 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 11, 2025
github-project-automation Bot moved this to Todo in Docs PRs Nov 11, 2025
bedevere-app Bot mentioned this pull request Nov 11, 2025
Open
ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 11, 2025
StanFromIreland reviewed Nov 11, 2025
View reviewed changes
Comment thread Doc/c-api/file.rst Outdated
Comment on lines +115 to +116
:c:expr:`const char*` that is decoded by the
:term:`filesystem encoding and error handler`.

StanFromIreland Nov 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

UTF-8 encoding, no (also implied by the parameter name)?

cpython/Objects/fileobject.c

Line 528 in d890aba

PyObject *pathobj = PyUnicode_FromString(utf8path);

ZeroIntensity Nov 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, good catch.

StanFromIreland reviewed Nov 11, 2025
View reviewed changes
Comment thread Doc/c-api/file.rst
StanFromIreland reviewed Nov 11, 2025
View reviewed changes
Comment thread Doc/c-api/file.rst Outdated
Update Doc/c-api/file.rst
145d2d2 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland approved these changes Nov 11, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity merged commit 2befce8 into python:main Nov 11, 2025
28 checks passed
ZeroIntensity deleted the document-pyfile branch November 11, 2025 20:31

miss-islington-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2025
pythongh-141004: Document PyFile_OpenCode and `PyFile_OpenCodeObjec…
ce8f6a8 
…t` (pythonGH-141413)

(cherry picked from commit 2befce8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

GH-141425 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2025
pythongh-141004: Document PyFile_OpenCode and `PyFile_OpenCodeObjec…
222148b 
…t` (pythonGH-141413)

(cherry picked from commit 2befce8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 11, 2025

Copy link
Copy Markdown

GH-141426 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2025
ZeroIntensity added a commit that referenced this pull request Nov 11, 2025
[3.14] gh-141004: Document PyFile_OpenCode and `PyFile_OpenCodeObje…
91f33ef 
…ct` (GH-141413) (GH-141425)

gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413)
(cherry picked from commit 2befce8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ZeroIntensity added a commit that referenced this pull request Nov 11, 2025
[3.13] gh-141004: Document PyFile_OpenCode and `PyFile_OpenCodeObje…
b28ba31 
…ct` (GH-141413) (GH-141426)

gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413)
(cherry picked from commit 2befce8)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: Document PyFile_OpenCode and `PyFile_OpenCodeObjec…
0fb5f91 
…t` (pythonGH-141413)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL