gh-141460: Simplify threading.RLock implementation by removing dead code - #141462
Conversation
Sorry, something went wrong.
The C implementation of RLock (_thread.RLock) is now always available on all supported platforms, making the Python fallback implementation and the factory function unnecessary. Changes: - Remove _RLock class (Python implementation) from Lib/threading.py - Replace RLock() factory function with direct alias to _thread.RLock - Remove _PyRLock and _CRLock aliases - Update tests to use threading.RLock instead of _PyRLock or _CRLock - Remove PyRLockTests class and merge CRLockTests into RLockTests - Update test_free_threading/test_monitoring.py to use RLock This simplification removes ~150 lines of dead code while maintaining full backward compatibility, as threading.RLock remains callable and returns the same C-based RLock instances as before.
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
|
Closing, seeing the CI this is pretty clearly not dead code. Removing public functions needs deprecation cycles too. Please open a discussion first. |
Sorry, something went wrong.
|
Ah, there is indeed already an issue for this. cc @larryhastings |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
|
Closing anyway; Claude is never going to sign the CLA. See also the devguide chapter on generative AI. |
Sorry, something went wrong.
The C implementation of RLock (_thread.RLock) is now always available on all supported platforms, making the Python fallback implementation and the factory function unnecessary.
Changes:
This simplification removes ~150 lines of dead code while maintaining full backward compatibility, as threading.RLock remains callable and returns the same C-based RLock instances as before.