FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141473: Fix subprocess.Popen.communicate to send input to stdin upon a subsequent post-timeout call by mrowqa · Pull Request #141477 · python/cpython · GitHub

Repository navigation

gh-141473: Fix subprocess.Popen.communicate to send input to stdin upon a subsequent post-timeout call - #141477

Merged
gpshead merged 5 commits into
python:mainfrom
mrowqa:fix-issue-141473
Nov 29, 2025
Merged

gpshead merged 5 commits into
python:mainfrom
mrowqa:fix-issue-141473

Conversation

mrowqa commented Nov 12, 2025 •
edited by gpshead
Loading

Copy link
Copy Markdown
Contributor

This fixes the reported bug and updates the documentation.

TODO:

  • add a regression test.

mrowqa requested a review from gpshead as a code owner November 12, 2025 18:50

python-cla-bot Bot commented Nov 12, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Nov 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

gpshead changed the title gh-141473: Fix subprocess.Popen.communicate to send input to stdin gh-141473: Fix subprocess.Popen.communicate to send input to stdin upon a subsequent post-timeout call Nov 27, 2025
gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 27, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 76a2622 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141477%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 27, 2025
gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Nov 27, 2025
gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 28, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 1bc972c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141477%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 28, 2025
gpshead merged commit 526d7a8 into python:main Nov 29, 2025
116 of 117 checks passed

Copy link
Copy Markdown

Thanks @mrowqa for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2025
…din upon a subsequent post-timeout call (pythonGH-141477)

* pythongh-141473: Fix subprocess.Popen.communicate to send input to stdin
* Docs: Clarify that `input` is one time only on `communicate()`
* NEWS entry
* Add a regression test.

---------
(cherry picked from commit 526d7a8)

Co-authored-by: Artur Jamro <artur.jamro@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Nov 29, 2025

Copy link
Copy Markdown

GH-142059 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 29, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2025
…din upon a subsequent post-timeout call (pythonGH-141477)

* pythongh-141473: Fix subprocess.Popen.communicate to send input to stdin
* Docs: Clarify that `input` is one time only on `communicate()`
* NEWS entry
* Add a regression test.

---------
(cherry picked from commit 526d7a8)

Co-authored-by: Artur Jamro <artur.jamro@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Nov 29, 2025

Copy link
Copy Markdown

GH-142060 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 29, 2025
gpshead added a commit that referenced this pull request Nov 29, 2025
…tdin upon a subsequent post-timeout call (GH-141477) (#142059)

gh-141473: Fix subprocess.Popen.communicate to send input to stdin upon a subsequent post-timeout call (GH-141477)

* gh-141473: Fix subprocess.Popen.communicate to send input to stdin
* Docs: Clarify that `input` is one time only on `communicate()`
* NEWS entry
* Add a regression test.

---------
(cherry picked from commit 526d7a8)

Co-authored-by: Artur Jamro <artur.jamro@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull request Nov 29, 2025
…tdin upon a subsequent post-timeout call (GH-141477) (#142060)

* gh-141473: Fix subprocess.Popen.communicate to send input to stdin upon a subsequent post-timeout call (GH-141477)

* gh-141473: Fix subprocess.Popen.communicate to send input to stdin
* Docs: Clarify that `input` is one time only on `communicate()`
* NEWS entry
* Add a regression test.

---------
(cherry picked from commit 526d7a8)

Co-authored-by: Artur Jamro <artur.jamro@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

* no assertStartsWith

---------

Co-authored-by: Artur Jamro <artur.jamro@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
mrowqa deleted the fix-issue-141473 branch November 29, 2025 15:20
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
…din upon a subsequent post-timeout call (pythonGH-141477)

* pythongh-141473: Fix subprocess.Popen.communicate to send input to stdin
* Docs: Clarify that `input` is one time only on `communicate()`
* NEWS entry
* Add a regression test.

---------

Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL