FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141488: Rename C API macro by Locked-chess-official · Pull Request #141493 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-141488: Rename C API macro - #141493

Merged
vstinner merged 11 commits into
python:mainfrom
Locked-chess-official:Rename_macro
Nov 14, 2025
ConversationCommits (11)ChecksFiles changed
Merged

gh-141488: Rename C API macro#141493
vstinner merged 11 commits into
python:mainfrom
Locked-chess-official:Rename_macro

Conversation

Locked-chess-official commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Found this condition appear in "datetime.h" and "minalloc "

modified: Include/datetime.h
2a99495 
	modified:   Include/internal/mimalloc/mimalloc.h
	modified:   Include/internal/mimalloc/mimalloc/atomic.h
	modified:   Include/internal/mimalloc/mimalloc/internal.h
	modified:   Include/internal/mimalloc/mimalloc/prim.h
	modified:   Include/internal/mimalloc/mimalloc/track.h
	modified:   Include/internal/mimalloc/mimalloc/types.h
add news
642ad1b
bedevere-app Bot mentioned this pull request Nov 13, 2025
Closed

sergey-miryanov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

I'm not sure it is a good idea to do changes in mimaloc.

ZeroIntensity reviewed Nov 13, 2025
View reviewed changes

ZeroIntensity left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we should touch mimalloc here, as that isn't exposed to public headers.

Edit: Sorry, missed Sergey's comment!

Locked-chess-official commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

cc @ZeroIntensity
I cancel all of the change in mimaloc

vstinner commented Nov 13, 2025

Copy link
Copy Markdown
Member

I'm not sure it is a good idea to do changes in mimaloc.

mimalloc changes should be proposed upstream first: https://github.com/microsoft/mimalloc/.

vstinner changed the title gh-141488:Rename macro gh-141488: Rename C API macro Nov 13, 2025

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

vstinner enabled auto-merge (squash) November 14, 2025 10:54
vstinner merged commit da7f4e4 into python:main Nov 14, 2025
44 checks passed
Locked-chess-official deleted the Rename_macro branch November 15, 2025 06:32
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141488: Add Py_ prefix to Include/datetime.h macros (pytho…
45b47b5 
…n#141493)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin
ZeroIntensity Awaiting requested review from ZeroIntensity

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL