FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: Document `PyOS_InterruptOccurred` by StanFromIreland · Pull Request #141526 · python/cpython · GitHub

/ cpython Public

gh-141004: Document PyOS_InterruptOccurred - #141526

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
StanFromIreland:PyOS_InterruptOccurred
Nov 14, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-141004: Document PyOS_InterruptOccurred#141526
ZeroIntensity merged 4 commits into
python:mainfrom
StanFromIreland:PyOS_InterruptOccurred

Conversation

StanFromIreland commented Nov 13, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Nov 13, 2025
Open
ZeroIntensity reviewed Nov 13, 2025
View reviewed changes
Comment thread Modules/signalmodule.c Outdated
Comment thread Doc/c-api/sys.rst Outdated
ZeroIntensity reviewed Nov 13, 2025
View reviewed changes
Comment thread Doc/c-api/sys.rst
ZeroIntensity reviewed Nov 13, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nearly there!

Comment thread Doc/c-api/sys.rst Outdated
Comment thread Doc/c-api/sys.rst
ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 13, 2025
ZeroIntensity approved these changes Nov 14, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity merged commit ef90261 into python:main Nov 14, 2025
32 checks passed

miss-islington-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2025
pythongh-141004: Document PyOS_InterruptOccurred (pythonGH-141526)
0ff6083 
(cherry picked from commit ef90261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

GH-141549 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 14, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2025
pythongh-141004: Document PyOS_InterruptOccurred (pythonGH-141526)
fd42c02 
(cherry picked from commit ef90261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

GH-141550 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 14, 2025
ZeroIntensity pushed a commit that referenced this pull request Nov 14, 2025
[3.14] gh-141004: Document PyOS_InterruptOccurred (GH-141526) (GH-1…
72a8ea7 
…41549)

gh-141004: Document `PyOS_InterruptOccurred` (GH-141526)
(cherry picked from commit ef90261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

vstinner commented Nov 14, 2025

Copy link
Copy Markdown
Member

The documentation doesn't mention that the function always returns 0 if called from a thread which is not the main thread, or an interpreter which is not the main interpreter. Only the main thread of the main interpreter can return 1.

ZeroIntensity commented Nov 14, 2025

Copy link
Copy Markdown
Member

I thought about that, but I didn't think it was particularly important; it's technically an implementation detail, it's not too noticeable in practice, and most people should use PyErr_CheckSignals anyway. Feel free to submit a follow-up PR if you feel strongly about documenting that.

ZeroIntensity pushed a commit that referenced this pull request Nov 14, 2025
[3.13] gh-141004: Document PyOS_InterruptOccurred (GH-141526) (GH-1…
c8c8cc2 
…41550)

gh-141004: Document `PyOS_InterruptOccurred` (GH-141526)
(cherry picked from commit ef90261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: Document PyOS_InterruptOccurred (pythonGH-141526)
265f87e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL