FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-141509: Fix warning about remaining subinterpreters by sergey-miryanov · Pull Request #141528 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-141509: Fix warning about remaining subinterpreters - #141528

Merged
ZeroIntensity merged 8 commits into
python:mainfrom
sergey-miryanov:141509-fix-suggestion-for-remaining-subinterpreters
Nov 14, 2025
ConversationCommits (8)ChecksFiles changed
Merged

GH-141509: Fix warning about remaining subinterpreters#141528
ZeroIntensity merged 8 commits into
python:mainfrom
sergey-miryanov:141509-fix-suggestion-for-remaining-subinterpreters

Conversation

sergey-miryanov commented Nov 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Fix warning - suggest using Interpreter.close instead of _interpeters.destroy.

@ZeroIntensity Could you please take a look?

bedevere-app Bot mentioned this pull request Nov 13, 2025
Closed
ZeroIntensity reviewed Nov 13, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  1. This changes a public API, so let's add a news entry.
  2. Since you didn't need to update any tests, that means that this code path is untested. Please add a test case for leaving subinterpreters unclosed.

sergey-miryanov marked this pull request as draft November 13, 2025 19:19

sergey-miryanov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Tests fail because of #131229

sergey-miryanov marked this pull request as ready for review November 13, 2025 19:56

sergey-miryanov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Could you please take a look?

ZeroIntensity reviewed Nov 13, 2025
View reviewed changes
Comment thread Lib/test/test_interpreters/test_api.py Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst Outdated
sergey-miryanov and others added 2 commits November 14, 2025 10:15
Update Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issu…
4df921d 
…e-141528.VWdax1.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Fix test and news
8eae319

sergey-miryanov commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

Fixed. Please take a look.

ZeroIntensity approved these changes Nov 14, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Nov 14, 2025

sergey-miryanov commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

Thanks!

ZeroIntensity enabled auto-merge (squash) November 14, 2025 11:28

ZeroIntensity commented Nov 14, 2025

Copy link
Copy Markdown
Member

Tests fail because of #131229

Ugh, that seems to fail consistently. I can't merge this until that job passes.

sergey-miryanov commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I'm looking into it, but without luck yet.

vstinner commented Nov 14, 2025

Copy link
Copy Markdown
Member

I reran the UBSan job (where test_import was failing).

ZeroIntensity commented Nov 14, 2025

Copy link
Copy Markdown
Member

I did too, but it still failed. It might pass if we rerun it enough times. See #141552 for a skip.

ZeroIntensity enabled auto-merge (squash) November 14, 2025 14:29
ZeroIntensity merged commit fa245df into python:main Nov 14, 2025
46 checks passed

miss-islington-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

Thanks @sergey-miryanov for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

Sorry, @sergey-miryanov and @ZeroIntensity, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fa245df4a0848c15cf8d907c10fc92819994b866 3.14

ZeroIntensity commented Nov 14, 2025

Copy link
Copy Markdown
Member

@sergey-miryanov Could you handle the backport?

sergey-miryanov commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Yeah, sure.

bedevere-app Bot commented Nov 14, 2025

Copy link
Copy Markdown

GH-141566 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 14, 2025
sergey-miryanov added a commit to sergey-miryanov/cpython that referenced this pull request Nov 14, 2025
[3.14] pythonGH-141509: Fix warning about remaining subinterpreters (p…
2ed943e 
…ythonGH-141528)

(cherry picked from commit fa245df)

Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity added a commit that referenced this pull request Nov 15, 2025
[3.14] GH-141509: Fix warning about remaining subinterpreters (GH-141528
21e43d5 
) (GH-141566)

(cherry picked from commit fa245df)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

sergey-miryanov commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for review!

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythonGH-141509: Fix warning about remaining subinterpreters (pythonG…
32190e8 
…H-141528)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

ZeroIntensity

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL