GH-141565: Add async code awareness to Tachyon - #141533
Conversation
Sorry, something went wrong.
|
@pablogsal Opening as draft for now so we can discuss 😄 |
Sorry, something went wrong.
…cpython into async-tachyon
|
@pablogsal Just took a look at the changes and things look really solid. I just pushed some more commits to fix a test/some UX inconsistencies but overall I think things look great. Really like the all/running modes too. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM! Excellent work @savannahostrowski. This is going to make such a big difference ❤️
Sorry, something went wrong.
|
@savannahostrowski there are some problems in windows and slow machines that I am investigating |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 47ebc11 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141533%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
I pushed a change with some windows fixes and tests and looks like this fixes all buildbots so I am merging. Congrats! This is amazing :) |
Sorry, something went wrong.
Before:
With --async-aware:
And just for posterity, here's what pstree returns for the program:
└── (T) Task-1 └── main /Users/savannah/code/cpython/sandbox/test_simple_async.py:59 └── wait_for /Users/savannah/code/cpython/Lib/asyncio/tasks.py:488 └── (T) Supervisor └── supervisor /Users/savannah/code/cpython/sandbox/test_simple_async.py:41 ├── (T) Worker-0 │ └── worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24 │ └── (T) LeafTask-0 │ └── leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13 │ └── sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702 ├── (T) Worker-1 │ └── worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24 │ └── (T) LeafTask-1 │ └── leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13 │ └── sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702 └── (T) Worker-2 └── worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24 └── (T) LeafTask-2 └── leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13 └── sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702```