FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-141004: document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN by skirpichev · Pull Request #141544 · python/cpython · GitHub

/ cpython Public

gh-141004: document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN - #141544

Merged
vstinner merged 9 commits into
python:mainfrom
skirpichev:docs-for-math-macros/141004
Nov 18, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-141004: document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN#141544
vstinner merged 9 commits into
python:mainfrom
skirpichev:docs-for-math-macros/141004

Conversation

skirpichev commented Nov 14, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 14, 2025
bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 14, 2025
github-project-automation Bot moved this to Todo in Docs PRs Nov 14, 2025
bedevere-app Bot mentioned this pull request Nov 14, 2025
Open
ZeroIntensity reviewed Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
ZeroIntensity approved these changes Nov 14, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I'm not too familiar with these math APIs. @vstinner, do you want to take a look?

StanFromIreland reviewed Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
StanFromIreland reviewed Nov 14, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suggest adding the parameters to the documentation, like is done for Py_RETURN_INF.

Comment thread Doc/c-api/float.rst Outdated
vstinner reviewed Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
Apply suggestions from code review
bb2bdcb 
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
skirpichev commented Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
skirpichev commented Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
skirpichev commented Nov 14, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
StanFromIreland reviewed Nov 15, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
Comment thread Doc/c-api/float.rst Outdated
Apply suggestions from code review
3c5edb5 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland approved these changes Nov 16, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner reviewed Nov 17, 2025
View reviewed changes
Comment thread Doc/c-api/float.rst Outdated
skirpichev requested a review from vstinner November 17, 2025 23:05
vstinner merged commit 630cd37 into python:main Nov 18, 2025
28 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 18, 2025

miss-islington-app Bot commented Nov 18, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 18, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 630cd37bfae0fc4021d9e9461b94d36e7ce6b95c 3.14

miss-islington-app Bot commented Nov 18, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 630cd37bfae0fc4021d9e9461b94d36e7ce6b95c 3.13

vstinner commented Nov 18, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

@skirpichev: Can you try to backport the change to 3.14?

skirpichev deleted the docs-for-math-macros/141004 branch November 18, 2025 09:35
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 18, 2025
[3.14] pythongh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS…
bdaf2b8 
…_NAN (pythonGH-141544)

(cherry picked from commit 630cd37)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented Nov 18, 2025

Copy link
Copy Markdown

GH-141698 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 18, 2025

bedevere-app Bot commented Nov 18, 2025

Copy link
Copy Markdown

GH-141700 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 18, 2025
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 18, 2025
[3.14] pythongh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS…
ef704f6 
…_NAN (pythonGH-141544)

(cherry picked from commit 630cd37)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner added a commit that referenced this pull request Nov 18, 2025
[3.14] gh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (G…
ed5c854 
…H-141544) (#141698)

(cherry picked from commit 630cd37)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner added a commit that referenced this pull request Nov 18, 2025
[3.13] gh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (G…
a5650e4 
…H-141544) (#141700)

(cherry picked from commit 630cd37)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (p…
d55c439 
…ython#141544)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
StanFromIreland StanFromIreland approved these changes
vstinner Awaiting requested review from vstinner

Assignees

vstinner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL