FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-44968: Add "Reload from Disk" feature to IDLE by ashm-dev · Pull Request #141574 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-44968: Add "Reload from Disk" feature to IDLE - #141574

Closed
ashm-dev wants to merge 127 commits into
python:mainfrom
ashm-dev:idle
ConversationCommits (127)ChecksFiles changed
Closed

gh-44968: Add "Reload from Disk" feature to IDLE#141574
ashm-dev wants to merge 127 commits into
python:mainfrom
ashm-dev:idle

Conversation

ashm-dev commented Nov 14, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Nov 14, 2025
Open
sharktide reviewed Nov 15, 2025
View reviewed changes
Comment thread Lib/idlelib/iomenu.py Outdated
sharktide reviewed Nov 15, 2025
View reviewed changes

sharktide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

ashm-dev and others added 2 commits November 15, 2025 09:47
Update Lib/idlelib/iomenu.py
884758b 
Co-authored-by: R.C.M <sharktidedev@gmail.com>
Simplify file reload by removing cursor restoration
d6f54a2 
Removed cursor position restoration logic during file reload.

ashm-dev commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

Rewrote it, now it won't save cursor position.

ashm-dev requested a review from sharktide November 15, 2025 07:24
picnixz previously requested changes Nov 15, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please rely more on unittest.mock.patch() as well as mock features directly. In addition add a What's New entry in addition to the NEWS entry.

Comment thread Lib/idlelib/idle_test/test_iomenu.py
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated

bedevere-app Bot commented Nov 15, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ashm-dev requested a review from AA-Turner as a code owner November 15, 2025 22:28

ashm-dev commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

python-cla-bot Bot commented Dec 8, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

ashm-dev closed this Dec 8, 2025
ashm-dev deleted the idle branch December 8, 2025 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz requested changes
terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
gpshead Awaiting requested review from gpshead gpshead is a code owner
berkerpeksag Awaiting requested review from berkerpeksag
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner
gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin
hugovk Awaiting requested review from hugovk hugovk is a code owner
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
freakboy3742 Awaiting requested review from freakboy3742
encukou Awaiting requested review from encukou encukou is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
sharktide sharktide left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL