Draft: gh-139103: Use _PyObject_GetMethodStackRef for slot_tp_new - #141603
Closed
eendebakpt wants to merge 9 commits into
Closed
Draft: gh-139103: Use _PyObject_GetMethodStackRef for slot_tp_new#141603eendebakpt wants to merge 9 commits into
eendebakpt wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eendebakpt
requested review from
ericsnowcurrently and
markshannon
as code owners
November 15, 2025 21:33
3 tasks
eendebakpt
commented
Nov 15, 2025
Comment thread
Objects/typeobject.c
Outdated
eendebakpt
commented
Nov 15, 2025
Comment thread
Objects/typeobject.c
Outdated
eendebakpt
commented
Nov 16, 2025
Comment thread
Misc/NEWS.d/next/Core_and_Builtins/2025-11-16-20-28-48.gh-issue-139103.gZNQMz.rst
Outdated
Copy link
Copy Markdown
Contributor
|
@eendebakpt: _PyObject_GetMethodStackRef is not going to be efficient here. It's only specialized if the passed in object's type has a tp->tp_getattro of PyObject_GenericGetAttr. In this case we are getting the __new__ function on a type instance. Typically a type's type is PyType_Type and that has tp_getattro of _Py_type_getattro. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use _PyObject_GetMethodStackRef for slot_tp_new to avoid refcount contention in namedtuple.
Marked draft: the free-threading bottleneck is not yet resolved