FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) by encukou · Pull Request #141657 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) - #141657

Merged
encukou merged 1 commit into
python:3.13from
encukou:backport-f2bce51-3.13
Nov 18, 2025
ConversationCommits (1)ChecksFiles changed
Merged

[3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835)#141657
encukou merged 1 commit into
python:3.13from
encukou:backport-f2bce51-3.13

Conversation

encukou commented Nov 17, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

pythongh-140691: urllib.request: Close FTP control socket if data soc…
dd39581 
…ket can't connect (pythonGH-140835)

Co-authored-by: codenamenam <bluetire27@gmail.com>
(cherry picked from commit f2bce51)
bedevere-app Bot mentioned this pull request Nov 17, 2025
Open
encukou changed the title gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) [3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) Nov 17, 2025
bedevere-app Bot mentioned this pull request Nov 17, 2025
Merged

efimov-mikhail commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This backport looks correct for me.
But why we don't provide a change to class WarningMessage?
I understand that Lib/_py_warnings.py could not be patched on 3.13, but we could patch Lib/warnings.py.

encukou commented Nov 17, 2025

Copy link
Copy Markdown
Member Author

That's not a bugfix, so when the conflict came up I removed the change.
The repr was rather useful for diagnostics, but I don't think it's that important in backports.

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 17, 2025

bedevere-bot commented Nov 17, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit dd39581 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141657%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 17, 2025
encukou merged commit 1bca1b4 into python:3.13 Nov 18, 2025
108 of 112 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

efimov-mikhail efimov-mikhail approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL