Repository navigation
gh-41779: Allow defining any __slots__ for a class derived from tuple - #141763
Merged
serhiy-storchaka merged 4 commits intoJan 6, 2026
Merged
serhiy-storchaka merged 4 commits into
serhiy-storchaka merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
requested review from
AA-Turner,
markshannon and
willingc
as code owners
November 19, 2025 18:50
encukou
reviewed
Nov 21, 2025
Comment thread
Objects/typeobject.c
Outdated
Comment thread
Python/specialize.c
Comment on lines
+814
to
+817
| if (dmem->flags & _Py_AFTER_ITEMS) { | ||
| SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_SLOT_AFTER_ITEMS); | ||
| return -1; | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks OK but I don't know enough about the specializer to review properly.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@markshannon Is this compatible with the laout you had in mind for the “Grand Unified Python Object Layout”? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Let's merge this, and fix possible issues if they occur later. |
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit 4d21297. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/725/builds/12464 Failed tests:
Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 24, done.
remote: Counting objects: 4% (1/23)
remote: Counting objects: 8% (2/23)
remote: Counting objects: 13% (3/23)
remote: Counting objects: 17% (4/23)
remote: Counting objects: 21% (5/23)
remote: Counting objects: 26% (6/23)
remote: Counting objects: 30% (7/23)
remote: Counting objects: 34% (8/23)
remote: Counting objects: 39% (9/23)
remote: Counting objects: 43% (10/23)
remote: Counting objects: 47% (11/23)
remote: Counting objects: 52% (12/23)
remote: Counting objects: 56% (13/23)
remote: Counting objects: 60% (14/23)
remote: Counting objects: 65% (15/23)
remote: Counting objects: 69% (16/23)
remote: Counting objects: 73% (17/23)
remote: Counting objects: 78% (18/23)
remote: Counting objects: 82% (19/23)
remote: Counting objects: 86% (20/23)
remote: Counting objects: 91% (21/23)
remote: Counting objects: 95% (22/23)
remote: Counting objects: 100% (23/23)
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 5% (1/20)
remote: Compressing objects: 10% (2/20)
remote: Compressing objects: 15% (3/20)
remote: Compressing objects: 20% (4/20)
remote: Compressing objects: 25% (5/20)
remote: Compressing objects: 30% (6/20)
remote: Compressing objects: 35% (7/20)
remote: Compressing objects: 40% (8/20)
remote: Compressing objects: 45% (9/20)
remote: Compressing objects: 50% (10/20)
remote: Compressing objects: 55% (11/20)
remote: Compressing objects: 60% (12/20)
remote: Compressing objects: 65% (13/20)
remote: Compressing objects: 70% (14/20)
remote: Compressing objects: 75% (15/20)
remote: Compressing objects: 80% (16/20)
remote: Compressing objects: 85% (17/20)
remote: Compressing objects: 90% (18/20)
remote: Compressing objects: 95% (19/20)
remote: Compressing objects: 100% (20/20)
remote: Compressing objects: 100% (20/20), done.
remote: Total 24 (delta 3), reused 3 (delta 3), pack-reused 1 (from 1)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '4d21297d288f17c0db775605e2543749840e46b2'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 4d21297d288 gh-41779: Allow defining any __slots__ for a class derived from tuple (GH-141763)
Switched to and reset branch 'main'
make: *** [buildbottest] Error 2 |
Sorry, something went wrong.
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141763.org.readthedocs.build/