FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT by colesbury · Pull Request #141804 · python/cpython · GitHub

/ cpython Public

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT - #141804

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:_PyConfig_GIL_DEFAULT
Nov 24, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT#141804
colesbury merged 1 commit into
python:mainfrom
colesbury:_PyConfig_GIL_DEFAULT

Conversation

colesbury commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Nov 20, 2025
Closed
colesbury marked this pull request as ready for review November 20, 2025 19:24
colesbury requested a review from encukou November 20, 2025 19:24
ayushHardeniya approved these changes Nov 20, 2025
View reviewed changes

ayushHardeniya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems good.

encukou approved these changes Nov 24, 2025
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

Process nitpick: It would be nice to group this with the actual code change. Consider amending the title of gh-116749, attaching this PR to that, and marking gh-116329 as duplicate.

colesbury changed the title gh-116329: Fix code comment for _PyConfig_GIL_DEFAULT gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT Nov 24, 2025
bedevere-app Bot mentioned this pull request Nov 24, 2025
Closed
colesbury merged commit c490ffb into python:main Nov 24, 2025
52 checks passed
colesbury deleted the _PyConfig_GIL_DEFAULT branch November 24, 2025 15:42
colesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025

miss-islington-app Bot commented Nov 24, 2025

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
927ebe5 
…-141804)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented Nov 24, 2025

Copy link
Copy Markdown

GH-141911 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury added a commit that referenced this pull request Nov 24, 2025
[3.14] gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (gh-141804…
cabaa47 
…) (gh-141911)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <colesbury@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
16cc2b2 
…-141804)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
5a8eb3e 
…-141804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
+1 more reviewer
ayushHardeniya ayushHardeniya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL