FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119786: Remove mention of `_PyThreadState_BumpFramePointer` from `InternalDocs/interpreter.md` by efimov-mikhail · Pull Request #141816 · python/cpython · GitHub

/ cpython Public

gh-119786: Remove mention of _PyThreadState_BumpFramePointer from InternalDocs/interpreter.md - #141816

Merged
hugovk merged 2 commits into
python:mainfrom
efimov-mikhail:issue-119786-interpreter-docs
Dec 16, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-119786: Remove mention of _PyThreadState_BumpFramePointer from InternalDocs/interpreter.md#141816
hugovk merged 2 commits into
python:mainfrom
efimov-mikhail:issue-119786-interpreter-docs

Conversation

efimov-mikhail commented Nov 21, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

In #93908 function _PyThreadState_BumpFramePointer was removed.
But we still have its mention in InternalDocs/interpreter.md.
I propose to remove it and slightly change wording around.
For example, functions _PyThreadState_HasStackSpace and _PyFrame_PushUnchecked could be mentioned.

CC @iritkatriel @markshannon

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 21, 2025
github-project-automation Bot moved this to Todo in Docs PRs Nov 21, 2025
bedevere-app Bot mentioned this pull request Nov 21, 2025
Closed
efimov-mikhail requested review from iritkatriel and markshannon and removed request for AA-Turner November 21, 2025 08:55
iritkatriel reviewed Nov 21, 2025
View reviewed changes
Comment thread InternalDocs/interpreter.md Outdated
Update InternalDocs/interpreter.md
7c78bb1 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

how far back does this needs back porting?

efimov-mikhail added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 21, 2025

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thx for the review, @iritkatriel!

Backporting to 3.13 and 3.14 seems to be optimal, since this change was landed to 3.12, and docs changes are definitely not a security fixes.
I've added those labels.

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

we can back port doc updates to security fix versions

efimov-mikhail removed the needs backport to 3.13 bugs and security fixes label Nov 21, 2025

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Actually, we can backport only to 3.14, since there's no InternalDocs/interpreter.md file on 3.13.
I forgot about it, sorry.

hugovk merged commit cf7a309 into python:main Dec 16, 2025
38 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Dec 16, 2025

miss-islington-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
pythongh-119786: Remove mention of _PyThreadState_BumpFramePointer …
7d0cb9b 
…from `InternalDocs/interpreter.md` (pythonGH-141816)

(cherry picked from commit cf7a309)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142812 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 16, 2025
hugovk pushed a commit that referenced this pull request Dec 16, 2025
[3.14] gh-119786: Remove mention of _PyThreadState_BumpFramePointer…
6545f24 
… from `InternalDocs/interpreter.md` (GH-141816) (#142812)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sergey-miryanov sergey-miryanov approved these changes
iritkatriel iritkatriel approved these changes
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL