FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-142029: Raise `ValueError` instead of crashing on empty name given to `create_builtin()` by dr-carlos · Pull Request #142033 · python/cpython · GitHub

/ cpython Public

gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin() - #142033

Merged
kumaraditya303 merged 9 commits into
python:mainfrom
dr-carlos:importlib-create-builtin
Dec 10, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin()#142033
kumaraditya303 merged 9 commits into
python:mainfrom
dr-carlos:importlib-create-builtin

Conversation

dr-carlos commented Nov 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Nov 28, 2025
Closed

dr-carlos commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This function isn't documented or tested anywhere already, so I haven't added a test.

sergey-miryanov commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

@dr-carlos Could you please add tests?

brettcannon previously requested changes Nov 28, 2025
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add tests.

bedevere-app Bot commented Nov 28, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

dr-carlos commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've added simple tests based on the errors thrown in create_builtin().

I have made the requested changes; please review again

bedevere-app Bot commented Nov 28, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-app Bot requested a review from brettcannon November 28, 2025 21:23
vstinner reviewed Dec 2, 2025
View reviewed changes
Comment thread Python/import.c Outdated
Comment thread Lib/test/test_import/__init__.py Outdated
Comment thread Lib/test/test_import/__init__.py Outdated
Comment thread Lib/test/test_import/__init__.py Outdated
vstinner mentioned this pull request Dec 2, 2025
Merged
dr-carlos changed the title gh-142029: Raise TypeError instead of crashing on empty name given to create_builtin() gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin() Dec 2, 2025
vstinner approved these changes Dec 2, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Python/import.c Outdated
Update formatting in import.c
705b473 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner dismissed brettcannon’s stale review December 3, 2025 10:34

Tests have been added.

dr-carlos commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Anything blocking this PR?

kumaraditya303 merged commit 7067126 into python:main Dec 10, 2025
46 checks passed
kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 10, 2025

miss-islington-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Thanks @dr-carlos for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Thanks @dr-carlos for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Sorry, @dr-carlos and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 70671267c11c562c6ca682eebf863616b258c20a 3.13

miss-islington-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Sorry, @dr-carlos and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 70671267c11c562c6ca682eebf863616b258c20a 3.14

kumaraditya303 removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 10, 2025

kumaraditya303 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

The bug is present in main only, skipping backport.

dr-carlos deleted the importlib-create-builtin branch December 15, 2025 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
kumaraditya303 kumaraditya303 approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees

kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL