gh-142038: Expand guard for types_world_is_stopped to fix debug builds without assertions - #142039
gh-142038: Expand guard for types_world_is_stopped to fix debug builds without assertions#142039vstinner merged 2 commits into
Conversation
Sorry, something went wrong.
… builds without assertions
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
| #define END_TYPE_DICT_LOCK() Py_END_CRITICAL_SECTION2() | ||
|
|
||
| #ifndef NDEBUG | ||
| #if !defined(NDEBUG) || defined(Py_Debug) |
There was a problem hiding this comment.
The name of the macro is not Py_Debug but Py_DEBUG And ideally, I think we should instead use Py_DEBUG rather than NDEBUG.
Sorry, something went wrong.
There was a problem hiding this comment.
Agreed, this should be just Py_DEBUG.
Sorry, something went wrong.
There was a problem hiding this comment.
We had that before, and that caused problems for non-debug builds with --with-assertions. This issue was then addressed by #140133, which, however, introduced a new problem with debug-without-assertions builds.
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
|
Can someone else reproduce #142038 issue? |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x Fedora Stable Clang Installed 3.x (tier-3) has failed when building commit f6f456f. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1645/builds/1663 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/test/test_profiling/test_sampling_profiler/test_modes.py", line 384, in test_gil_mode_integration_behavior
with test_subprocess(gil_test_script) as subproc:
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/contextlib.py", line 141, in __enter__
return next(self.gen)
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.15/test/test_profiling/test_sampling_profiler/helpers.py", line 85, in test_subprocess
raise RuntimeError(
f"Unexpected response from subprocess: {response!r}"
)
RuntimeError: Unexpected response from subprocess: b'readythreads_ready'
|
Sorry, something went wrong.
…ug builds without assertions (python#142039)
The types_world_is_stopped() function needs to be defined if NDEBUG or when we're in a debug build is not defined.
Issue: