FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-131372: only install build-details.json in the main install by FFY00 · Pull Request #142269 · python/cpython · GitHub

/ cpython Public

GH-131372: only install build-details.json in the main install - #142269

Merged
FFY00 merged 3 commits into
python:mainfrom
FFY00:gh-131372
Dec 9, 2025
Merged

GH-131372: only install build-details.json in the main install#142269
FFY00 merged 3 commits into
python:mainfrom
FFY00:gh-131372

Conversation

FFY00 commented Dec 4, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Filipe Laíns <lains@riseup.net>

Copy link
Copy Markdown
Member

@FFY00 I just noticed all those cat commands being used for install steps and, without looking further into it, I wonder if those might be opening up some security issues. Typically, we use the install utility which does ensure specific permissions etc on installed files, something cat would not do.

FFY00 commented Dec 4, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

cat is only reading the build directory location here, install still does all the actual file touching.

That said, I really don't like this ideom. It has been around for a while, but unfortunately it's not easy to get rid of. I attempted it in GH-131761, but haven't had time to follow it through.

Copy link
Copy Markdown
Member

cat is only reading the build directory location here, install still does all the actual file touching.

D'oh, sorry for the noise!

FFY00 merged commit bcb6cbd into python:main Dec 9, 2025
42 checks passed

mgorny commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

This change makes no sense to me. IIUC the difference between altinstall and install was only that the latter additionally installed python and python3 symlinks. These are undesirable to distributions that support multiple Python versions and handle switching themselves, hence we use altinstall. I don't see why build-details.json that is installed inside the directory for a single Python version would be controlled by the same knob.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL