Repository navigation
gh-123241: Make gc_free_threading.c more robust to increfs/decrefs in tp_traverse - #142271
Draft
colesbury wants to merge 3 commits into
Draft
colesbury wants to merge 3 commits into
colesbury wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…efs in `tp_traverse` The GC for the free threading build reuses `ob_ref_local` when determining if any objects in the unreachable set were resurrected. This is generally okay because the refcount fields are already merged. However, if the tp_traverse calls `Py_INCREF`/`Py_DECREF`, it may see an `ob_ref_local` of `UINT32_MAX` that looks like an immortal object. Refactor `handle_resurrected_objects` so that `ob_ref_local` doesn't reach `UINT32_MAX`.
This comment was marked as outdated.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GC for the free threading build reuses ob_ref_local when determining if any objects in the unreachable set were resurrected. This is generally okay because the refcount fields are already merged. However, if the tp_traverse calls Py_INCREF/Py_DECREF, it may see an ob_ref_local of UINT32_MAX that looks like an immortal object.
Refactor handle_resurrected_objects so that ob_ref_local doesn't reach UINT32_MAX.