| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
If we just add it to the docs like this, how are maintainers of old code expected to find out about it? AFAICS, this is a new requirement, and making CPython rely on it will be a breaking change. |
Sorry, something went wrong.
This was unfortunately always a requirement for correctness but we never documented it. Calling it a "new requirement" is probably not very productive because if you were doing this before you have a bug and you can affect the correctness of the algorithm or crash depending on the version and the situation. We could perhaps raise some warnings with time time cost in debug build by checking the total ref count. |
Sorry, something went wrong.
|
Arguably the "create or destroy" objects is redundant given that involves modifying a reference count but LGTM. |
Sorry, something went wrong.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
…ons (pythongh-142272) (cherry picked from commit 37988c5) Co-authored-by: Sam Gross <colesbury@gmail.com>
…ons (pythongh-142272) (cherry picked from commit 37988c5) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-142422 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
|
GH-142423 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
📚 Documentation preview 📚: https://cpython-previews--142272.org.readthedocs.build/