Repository navigation
GH-142305: JIT: Deduplicating GOT symbols in the trace - #142316
Merged
diegorusso merged 3 commits intoDec 10, 2025
Merged
diegorusso merged 3 commits into
diegorusso merged 3 commits into
Conversation
diegorusso
requested review from
brandtbucher and
savannahostrowski
as code owners
December 5, 2025 17:22
savannahostrowski
requested changes
Dec 8, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just a question about the design choice!
Meta comment: man, I feel like GitHub has done this to me twice now where it's posted stale comments and/or eaten comments I've written during review...
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Comment thread
Python/jit.c
savannahostrowski
approved these changes
Dec 10, 2025
Comment thread
Python/jit.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.