Repository navigation
gh-142307: deprecate legacy support for altering IMAP4.file - #142335
Merged
hugovk merged 4 commits intoMay 6, 2026
Merged
hugovk merged 4 commits into
hugovk merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The ``IMAP4.file`` attribute was never meant to be part of the public API. Previously, this attribute was created when opening a connection but subsequent changes may introduce a desynchronization with the underlying socket as the previous file is not closed.
picnixz
commented
Dec 6, 2025
Comment thread
Lib/test/test_imaplib.py
Outdated
gpshead
approved these changes
Feb 7, 2026
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hang on, will fix this conflict resolution. |
Sorry, something went wrong.
hugovk
approved these changes
May 6, 2026
Copy link
Copy Markdown
Documentation build overview8 files changed · ± 8 modified ± Modified |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IMAP4.file attribute was never meant to be part of the public API. Previously, this attribute was created when opening a connection but subsequent changes may introduce a desynchronization with the underlying socket as the previous file is not closed.
📚 Documentation preview 📚: https://cpython-previews--142335.org.readthedocs.build/