Repository navigation
[3.14] gh-142307: restore legacy support for altering IMAP4.file - #142336
Closed
picnixz wants to merge 1 commit into
Closed
picnixz wants to merge 1 commit into
picnixz wants to merge 1 commit into
Conversation
gpshead
approved these changes
Feb 7, 2026
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I wonder, is it worth to initialize the file lazily?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
And I think it would be easier to review if apply this change to main, and add a deprecation on to of it in a separate PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Ah I can do it as well. I just didn't want an un-necessary commit in main but I can rebase it on main and follow-up with the other PR that adds the deprecation |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Since the rebase went bad on my side, I'll just recreate that PR against main: #145071. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.