FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138122: Integrate live profiler TUI with _colorize theming system by pablogsal · Pull Request #142360 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-138122: Integrate live profiler TUI with _colorize theming system - #142360

Merged
pablogsal merged 11 commits into
python:mainfrom
pablogsal:gh-138122-colors
Jan 1, 2026
ConversationCommits (11)ChecksFiles changed
Merged

gh-138122: Integrate live profiler TUI with _colorize theming system#142360
pablogsal merged 11 commits into
python:mainfrom
pablogsal:gh-138122-colors

Conversation

pablogsal commented Dec 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The Tachyon profiler's curses-based TUI now uses the centralized theming
infrastructure in _colorize.py, enabling users to customize colors via
the standard Python theming API. This adds a LiveProfiler theme section
with two pre-configured themes: the default dark theme optimized for
dark terminal backgrounds, and LiveProfilerLight for white/light
backgrounds. Users can switch themes by calling _colorize.set_theme() in
their PYTHONSTARTUP or sitecustomize.py.

The table header rendering was also improved to draw a continuous
background, eliminating visual gaps between columns when using reverse
video styling.

pablogsal requested a review from hugovk as a code owner December 6, 2025 19:50
pablogsal requested a review from ambv December 6, 2025 19:50
bedevere-app Bot mentioned this pull request Dec 6, 2025
Closed
pythongh-138122: Integrate live profiler TUI with _colorize theming s…
b024e50 
…ystem

The Tachyon profiler's curses-based TUI now uses the centralized theming
infrastructure in _colorize.py, enabling users to customize colors via
the standard Python theming API. This adds a LiveProfiler theme section
with two pre-configured themes: the default dark theme optimized for
dark terminal backgrounds, and LiveProfilerLight for white/light
backgrounds. Users can switch themes by calling _colorize.set_theme() in
their PYTHONSTARTUP or sitecustomize.py.

The table header rendering was also improved to draw a continuous
background, eliminating visual gaps between columns when using reverse
video styling.

picnixz commented Dec 7, 2025

Copy link
Copy Markdown
Member

Users can switch themes by calling _colorize.set_theme() in their PYTHONSTARTUP or sitecustomize.py.

I thought that this wasn't yet ready for public interface? should we really advertise this feature in the NEWS (cc @hugovk)

picnixz reviewed Dec 7, 2025
View reviewed changes
Comment thread Lib/_colorize.py

pablogsal commented Dec 7, 2025

Copy link
Copy Markdown
Member Author

Users can switch themes by calling _colorize.set_theme() in their PYTHONSTARTUP or sitecustomize.py.

I thought that this wasn't yet ready for public interface? should we really advertise this feature in the NEWS (cc @hugovk)

Is not but eventually that will be the mechanism. I can change the news entry if you want

picnixz commented Dec 7, 2025

Copy link
Copy Markdown
Member

Originally, I preferred not advertising this interface officially for now otherwise users could assume that they can freely use it as they want (and we don't know how we eventually want to document and expose it) but I saw that we had other NEWS entries that mentioned _colorize so... maybe just say that changing this should be at their own risk?

hugovk commented Dec 9, 2025

Copy link
Copy Markdown
Member

Yep, hopefully we'll have something public for 3.15. In the meantime we could say experimental.

hugovk reviewed Dec 9, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-12-06-19-49-20.gh-issue-138122.m3EF9E.rst Outdated
Comment thread Lib/_colorize.py
Comment thread Lib/_colorize.py Outdated
Comment thread Lib/_colorize.py Outdated
Comment thread Lib/_colorize.py Outdated
Comment thread Lib/_colorize.py Outdated
Comment thread Lib/profiling/sampling/live_collector/collector.py Outdated
Comment thread Lib/profiling/sampling/live_collector/collector.py Outdated
Comment thread Lib/profiling/sampling/live_collector/collector.py Outdated
pablogsal and others added 5 commits December 9, 2025 14:55
Update 2025-12-06-19-49-20.gh-issue-138122.m3EF9E.rst
b1f1a93 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Update _colorize.py
5ccaa25 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Update _colorize.py
2e42a81 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Update _colorize.py
5bd5b75 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Update _colorize.py
214a339 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
StanFromIreland mentioned this pull request Dec 21, 2025
Closed
pablogsal requested review from hugovk and picnixz December 28, 2025 15:08
picnixz reviewed Jan 1, 2026
View reviewed changes
Comment thread Lib/_colorize.py
Comment thread Lib/_colorize.py Outdated

pablogsal commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

Fixed merge conflicts

pablogsal commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

I think everything should be addressed by now.

picnixz approved these changes Jan 1, 2026
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I like the mention about "experimental API" but this also makes me wonder whether we should have some "Experimental" section. Do we have APIs in mind that are experimental except _colorize? (C++ had, for a very long time, only experimental::filesystem as an experimental namespace, so having only 1 component in an experimental section would still makes sense IMO).

pablogsal commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

Do we have APIs in mind that are experimental except _colorize?

That's pending for @hugovk and @ambv. My understanding is that they plan to expose something in 3.15

pablogsal commented Jan 1, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review @picnixz ❤️

pablogsal merged commit e5ad7b7 into python:main Jan 1, 2026
59 checks passed
pablogsal deleted the gh-138122-colors branch January 1, 2026 21:10
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-138122: Integrate live profiler TUI with _colorize theming s…
61541b4 
…ystem (python#142360)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
ambv Awaiting requested review from ambv
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL