| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
|
I have a comment not related to this PR, but I just want to have your input @zooba
This is fair but what about running on a true 32-bit OS? I see i686-pc-windows-msvc is "still" in tier-1. It made sense 10-15 years ago, but what about today? Is it still so popular/used out there? I'm more than happy to move the conversation on DPO if you think we need more discussion. |
Sorry, something went wrong.
Yeah, especially since the JIT is having a hard time on x86 due to spilling (because there are so few registers). @brandtbucher 's PR for preserve_none x86 llvm/llvm-project#150106 will help, but it seems stalled. Tailcalling doesn't work on Windows x86 (upcoming #139962), because MSVC doesn't support it for x86 (at least not in VS 2026, no idea whether this will ever be supported). There was a long discussion in https://discuss.python.org/t/consider-downgrading-windows-32-bit-from-tier-1-to-tier-2-or-tier-3-in-python-3-13/33719, but the outcome was to keep Windows x86 in tier-1. And the 32bit installer link was ranked after the 64bit installer on python.org so unaware people less likely choose it over 64bit 🚀
Even though Windows 10 is EOL (which was the last one where you could choose between 32bit/64bit when installing) and Windows 11 is 64bit only during installing, there is the compatibility layer to run 32bit software in 64bit Windows.
One outcome in the above discussion was, that 1
This might no longer be true for the JIT? Footnotes |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks Savannah for your patience on getting this implemented. I think it behaves as it should be and LGTM. I prefer though if you have the blessing of some Windows expert :)
Sorry, something went wrong.
|
LGTM. Maybe we can somewhere document that get_external.py does react on the environment variable PreferredToolArchitecture to override the llvm tool architecture that is used to build the stencils? E.g. in Tools/README.md? Sorry to be picky. Final decision is anyway up to Steve ... |
Sorry, something went wrong.
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
There was a problem hiding this comment.
Thanks Savannah!
Sorry, something went wrong.
|
Thanks for reviewing @chris-eibl! Appreciate it! |
Sorry, something went wrong.
|
Given that this has gotten a stamp from Diego and Chris (and I know Steve is out for quite some time), I will merge this. I am happy to revisit any and all parts if there is additional feedback! Thank you all for the reviews! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR adds support for downloading platform-specific LLVM binaries (AMD64, ARM64) instead of using a single binary with emulation (see https://github.com/python/cpython-bin-deps/releases/tag/llvm-21.1.4.0 for release artifacts). Since this won't naturally trigger jit.yml, you can see a successful run here, including print statements to show that we are in fact downloading the correct binary 😄.