| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…_impl V is not even defined here.
There was a problem hiding this comment.
Thanks, that's a typo, introduced by ef4dd1d.
Sorry, something went wrong.
|
Any update on this? |
Sorry, something went wrong.
|
Thanks @AZero13 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
|
Sorry, @AZero13 and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 7dca4e3af118328d7013b58106d129b162047cb3 3.14 |
Sorry, something went wrong.
…ITY (pythonGH-142441) There was a typo in _decimal.Context.apply().
|
Hi everyone, I ran into a compile error near the changes in this PR. ./Modules/_decimal/_decimal.c:6996:12: error: too few arguments to function '_decimal_Context__apply'
6996 | return _decimal_Context__apply(context, x);
| ^~~~~~~~~~~~~~~~~~~~~~~
I think the issue goes beyond a typo: the wrapper is calling the wrong function. It should call _decimal_Context__apply_impl(context, cls, x) instead of _decimal_Context__apply(context, x). After making that change, I was able to build successfully and run the decimal tests. @skirpichev @serhiy-storchaka Would this fix be acceptable? If so, I’m happy to open a PR. Thanks! update: I have opened a PR #152871, please have a look, thanks |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
V is not even defined here.