gh-138122: Add docs button to Tachyon heatmap and flamegraph - #142614
Merged
pablogsal merged 1 commit intoDec 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
approved these changes
Dec 12, 2025
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Amazing work sir!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have also converted it to use SVG's from bootstrap icons, I can revert back to characters if you prefer. This is because I had difficulties with the characters, it was difficult to align them, e.g. it ended up looking like this:
With SVG's, we have more control over how it renders, with this PR:
And, this PR also introduces a new docs (book) button that links to: