Repository navigation
GH-142646: Update Tachyon to use backtick formatting in CLI help - #142647
Merged
pablogsal merged 3 commits intoDec 13, 2025
Merged
pablogsal merged 3 commits into
pablogsal merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Lib/profiling/sampling/cli.py
|
|
||
| _HELP_DESCRIPTION = """Sample a process's stack frames and generate profiling data. | ||
|
|
||
| Commands: |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I found this pretty redundant given that we have the same info in positional args. I can revert if someone disagrees?
Before:
After:
Sorry, something went wrong.
hugovk
approved these changes
Dec 12, 2025
StanFromIreland
approved these changes
Dec 12, 2025
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
pablogsal
approved these changes
Dec 13, 2025
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is a great improvement
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After:
