IMO it's a good idea to use the Python version as the HTTP server version.
However, the Python version is already part of the combined version string: "BaseHTTP/0.6 Python/3.15.0".
This is made up of:
defversion_string(self):
"""Return the server software version string."""returnself.server_version+' '+self.sys_version
And the comments say server_version can be a name without a version:
# The Python system version, truncated to its first component.sys_version="Python/"+sys.version.split()[0]
# The server software version. You may want to override this.# The format is multiple whitespace-separated strings,# where each string is of the form name[/version].server_version="BaseHTTP/"+__version__
So better to have something like "BaseHTTP Python/3.15.0" rather than "BaseHTTP/3.15.0 Python/3.15.0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the issue @vstinner said:
However, the Python version is already part of the combined version string: "BaseHTTP/0.6 Python/3.15.0".
This is made up of:
And the comments say server_version can be a name without a version:
So better to have something like "BaseHTTP Python/3.15.0" rather than "BaseHTTP/3.15.0 Python/3.15.0".
📚 Documentation preview 📚: https://cpython-previews--142658.org.readthedocs.build/