gh-138122: Add some screenshots to the profiling.sampling docs - #142676
Merged
pablogsal merged 8 commits intoDec 14, 2025
Merged
gh-138122: Add some screenshots to the profiling.sampling docs#142676pablogsal merged 8 commits into
pablogsal merged 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some thoughts:
- To start, great idea :-)
- Maybe put the images in a folder for organisation?
- Did you optimise the pngs? (For one way to do this see, #139061)
- What do you think about adding an example tachyon-flamegraph.html to _static?
Sorry, something went wrong.
Comment thread
Doc/library/tachyon-pstats.png
Copy link
Copy Markdown
Member
Author
|
All done |
Sorry, something went wrong.
pablogsal
force-pushed
the
tachyon-images
branch
3 times, most recently
from
dd0eb7b to
d5a75fb
Compare
December 13, 2025 19:31
pablogsal
force-pushed
the
tachyon-images
branch
from
d5a75fb to
ba2b258
Compare
December 13, 2025 19:33
Comment thread
Doc/_static/tachyon-example-flamegraph.html
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Comment thread
Doc/library/profiling.sampling.rst
Outdated
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
approved these changes
Dec 14, 2025
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review everyone! |
Sorry, something went wrong.
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 16, 2025
…ython#142676) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142676.org.readthedocs.build/en/142676/library/profiling.sampling.html