FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-142594: fix by property calls io.TextIOWrapper.detach by yihong0618 · Pull Request #142706 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-142594: fix by property calls io.TextIOWrapper.detach - #142706

Merged
encukou merged 4 commits into
python:mainfrom
yihong0618:hy/close_issue_142594
Dec 15, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-142594: fix by property calls io.TextIOWrapper.detach#142706
encukou merged 4 commits into
python:mainfrom
yihong0618:hy/close_issue_142594

Conversation

yihong0618 commented Dec 14, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

fix: close issue 142594 property calls io.TextIOWrapper.detach
d936ccb 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618 changed the title fix: close issue 142594 property calls io.TextIOWrapper.detach gh-142594: fix by property calls io.TextIOWrapper.detach Dec 14, 2025
bedevere-app Bot mentioned this pull request Dec 14, 2025
Closed
fix: fix warning and move news to library
5435f7a 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
docs: try to fix warning
8b739f0 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618 marked this pull request as ready for review December 14, 2025 11:09
cmaloney approved these changes Dec 14, 2025
View reviewed changes

cmaloney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Update Misc/NEWS.d/next/Library/2025-12-14-18-30-48.gh-issue-142594.b…
98a653d 
…elDmD.rst

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
serhiy-storchaka approved these changes Dec 15, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Dec 15, 2025
encukou merged commit 1d3854a into python:main Dec 15, 2025
54 checks passed

miss-islington-app Bot commented Dec 15, 2025

Copy link
Copy Markdown

Thanks @yihong0618 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Dec 15, 2025

Copy link
Copy Markdown

Sorry, @yihong0618 and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1d3854a19a376c1fc7f71e96c620f6bc2de8cd74 3.14

miss-islington-app Bot commented Dec 15, 2025

Copy link
Copy Markdown

Sorry, @yihong0618 and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1d3854a19a376c1fc7f71e96c620f6bc2de8cd74 3.13

cmaloney commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

(Working on the backports; auto failed because of my refactor / move of test_io tests)

bedevere-app Bot commented Dec 15, 2025

Copy link
Copy Markdown

GH-142755 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 15, 2025
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Dec 15, 2025
[3.14] pythongh-142594: fix by property calls io.TextIOWrapper.detach (…
e055ec6 
…pythonGH-142706)

(cherry picked from commit 1d3854a)

Co-authored-by: yihong <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Dec 15, 2025
[3.13] pythongh-142594: fix by property calls io.TextIOWrapper.detach (…
148763a 
…pythonGH-142706)

(cherry picked from commit 1d3854a)

Co-authored-by: yihong <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

bedevere-app Bot commented Dec 15, 2025

Copy link
Copy Markdown

GH-142757 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Dec 15, 2025
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
pythongh-142594: fix by property calls io.TextIOWrapper.detach (pytho…
48bcca5 
…nGH-142706)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
encukou pushed a commit that referenced this pull request Dec 16, 2025
[3.14] gh-142594: fix by property calls io.TextIOWrapper.detach (GH-1…
58da2a9 
…42706) (GH-142755)

(cherry picked from commit 1d3854a)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
encukou pushed a commit that referenced this pull request Dec 16, 2025
[3.13] gh-142594: fix by property calls io.TextIOWrapper.detach (GH-1…
affd2f2 
…42706) (GH-142757)

(cherry picked from commit 1d3854a)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>

bedevere-bot commented Dec 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.14 (no tier) has failed when building commit 58da2a9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1687/builds/774) and take a look at the build logs.
  4. Check if the failure is related to this commit (58da2a9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1687/builds/774

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/test_annotationlib.py"�[0m, line �[35m160�[0m, in �[35mtest_nonexistent_attribute�[0m
    �[31mself.assertEqual�[0m�[1;31m(epsilon_anno, support.EqualToForwardRef("some | {obj, module}", owner=f))�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;35mAssertionError�[0m: �[35mForwardRef('some | {module, obj}', owner=[79 chars]f48>) != EqualToForwardRef('some | {obj, module}',[86 chars]f48>)�[0m


Traceback (most recent call last):
  File "/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/__init__.py", line 847, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/test_annotationlib.py"�[0m, line �[35m160�[0m, in �[35mtest_nonexistent_attribute�[0m
    �[31mself.assertEqual�[0m�[1;31m(epsilon_anno, support.EqualToForwardRef("some | {obj, module}", owner=f))�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;35mAssertionError�[0m: �[35mForwardRef('some | {module, obj}', owner=[79 chars]e98>) != EqualToForwardRef('some | {obj, module}',[86 chars]e98>)�[0m

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cmaloney cmaloney approved these changes
StanFromIreland StanFromIreland left review comments
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

encukou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL