gh-138122: Improve bytecode panel - #142910
Merged
pablogsal merged 1 commit intoDec 18, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The bytecode panel appears when a user generates a heatmap with --opcodes and clicks the button to unfold a line and display the bytecode instructions. Currently, an empty space appears on the left where the line number, self, and total columns are displayed. This area should instead extend those columns, rather than leaving a gap.
Copy link
Copy Markdown
Member
|
@lkollar @hugovk @savannahostrowski @StanFromIreland @AA-Turner I am curious what you think about this UX. @ivonastojanovic and myself were discussing how this should look. I particularly like that when you click the arrow it looks like the source line "unfolds" and shows the bytecode internals but the original versions is too wide and the data is too spread around. On the other hand this looks "more" like a popup. What do you folks think? |
Sorry, something went wrong.
hugovk
approved these changes
Dec 18, 2025
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yes, this looks better 👍
Sorry, something went wrong.
lkollar
approved these changes
Dec 18, 2025
pablogsal
approved these changes
Dec 18, 2025
Copy link
Copy Markdown
Member
|
Amazing 👌 |
Sorry, something went wrong.
cocolato
pushed a commit
to cocolato/cpython
that referenced
this pull request
Dec 18, 2025
The bytecode panel appears when a user generates a heatmap with --opcodes and clicks the button to unfold a line and display the bytecode instructions. Currently, an empty space appears on the left where the line number, self, and total columns are displayed. This area should instead extend those columns, rather than leaving a gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bytecode panel appears when a user generates a heatmap with --opcodes and clicks the button to unfold a line and display the bytecode instructions. Currently, an empty space appears on the left where the line number, self, and total columns are displayed. This area should instead extend those columns, rather than leaving a gap.
Before:
Screen.Recording.2025-12-18.at.00.08.34.movNow:
Screen.Recording.2025-12-18.at.00.03.09.mov