gh-122581: Use parser mutex in default build for subinterpreters - #142959
Merged
colesbury merged 1 commit intoDec 20, 2025
Merged
gh-122581: Use parser mutex in default build for subinterpreters#142959colesbury merged 1 commit into
colesbury merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This was caught by running ./python -m test test_datetime -m test_concurrent_initialization_subinterpreter -v with TSan, but that test still can't be enabled because there are other unfixed data races. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ouch, I wrote that test as part of #136583. What other races are you seeing? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@ZeroIntensity - Mostly things from #129824 |
Sorry, something went wrong.
ZeroIntensity
approved these changes
Dec 20, 2025
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There's not much else to discuss here, LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data race also affected subinterpreters in the default build.