gh-129069: fix more thread safety issues in list - #143019
Merged
kumaraditya303 merged 1 commit intoDec 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kumaraditya303
force-pushed
the
atomic-list
branch
from
8830614 to
908a590
Compare
December 20, 2025 12:30
colesbury
approved these changes
Dec 22, 2025
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
I didn't measure any significant performance difference on fastbench on Apple M4.
Microbenchmarks for list.insert are a little slower on that same machine. Here's the benchmark (courtesy of ChatGPT):
https://gist.github.com/colesbury/b675c95d35f29ca9d5723b95396d48a8
Before:
begin n=100000 reps=1000 total=0.032732s avg=32.73µs/op middle n=100000 reps=1000 total=0.013755s avg=13.76µs/op end n=100000 reps=1000 total=0.000564s avg=0.56µs/op
After:
begin n=100000 reps=1000 total=0.048336s avg=48.34µs/op middle n=100000 reps=1000 total=0.019781s avg=19.78µs/op end n=100000 reps=1000 total=0.000191s avg=0.19µs/op
We could use ptr_wise_atomic_memmove in many of these places, which will probably be faster in the microbenchmarks, but I'm not sure it'll matter in real programs.
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-153791 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes thread safety of list.reverse and slice assignment. Also changes stores to use release rather than relaxed as done in #142957.