| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I hate this, but I hate the other options even more. |
Sorry, something went wrong.
There was a problem hiding this comment.
We'll end up seeing the warning if clang's analysis gets more capable, right? I guess that's still better than disabling warnings around the block in the default build.
Test failure looks unrelated.
Sorry, something went wrong.
I think it's more a matter of convention than capability. Clang can easily optimize through all these things and this warning is only enabled in optimized builds (not debug builds). Clang doesn't warn for things like: if (1) {
}
unreachable_code; // OK
But it warns for: if ((expr, 1)) {
}
unreachable_code; // warning: code will never be executed [-Wunreachable-code]
But not for: if ((expr, 1) || (1)) {
}
unreachable_code; // OK
But you can't put that expression in a macro: #define MACRO (expr, 1) || (1)
if (MACRO) {
}
unreachable_code; // warning: code will never be executed [-Wunreachable-code]
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.