gh-140870: Full coverage for _pyrepl._module_completer - #143244
Merged
tomasr8 merged 2 commits intoDec 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
loic-simon
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
December 28, 2025 12:28
tomasr8
approved these changes
Dec 28, 2025
tomasr8
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thanks! The All required checks pass failed for some reason so I'm just gonna merge main to trigger a new run..
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @loic-simon for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 28, 2025
Copy link
Copy Markdown
|
GH-143260 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…143244) Full coverage for _pyrepl._module_completer Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(split from #140871 as recommanded by @tomasr8)
Add a few tests to get the coverage rate of _pyrepl._module_completer to ~100%:
The only statement left is the import under if TYPE_CHECKING, as expected.