FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143346: Fix calculation of the line width for wrapped Base64 in plistlib by serhiy-storchaka · Pull Request #143347 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-143346: Fix calculation of the line width for wrapped Base64 in plistlib - #143347

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:plistlib-base64-indent
Jan 12, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-143346: Fix calculation of the line width for wrapped Base64 in plistlib#143347
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:plistlib-base64-indent

Conversation

serhiy-storchaka commented Jan 2, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

It was incorrect in case of mixed tabs and spaces in indentation.

bedevere-app Bot mentioned this pull request Jan 2, 2026
Closed
serhiy-storchaka commented Jan 2, 2026
View reviewed changes
Comment thread Lib/test/test_plistlib.py
b'</array>\n'
b'</plist>\n')

pl = dumps_with_indent(data, b' \t')

serhiy-storchaka Jan 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This catches the original bug.

Comment thread Lib/test/test_plistlib.py
b'</array>\n'
b'</plist>\n')

pl = dumps_with_indent(data, b'\t ')

serhiy-storchaka Jan 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This catches a bug in my initial fix in #143216.

Comment thread Lib/test/test_plistlib.py
writer.write(data)
return fp.getvalue()

pl = dumps_with_indent(data, b' ')

serhiy-storchaka Jan 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This tests non-default indentation.

serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 2, 2026
pythongh-143346: Fix calculation of the line width for wrapped Base64…
389a103 
… in plistlib

It was incorrect in case of mixed tabs and spaces in indentation.
serhiy-storchaka merged commit 5f28aa2 into python:main Jan 12, 2026
46 checks passed

miss-islington-app Bot commented Jan 12, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

serhiy-storchaka deleted the plistlib-base64-indent branch January 12, 2026 08:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2026
pythongh-143346: Fix calculation of the line width for wrapped Base64…
2fe821c 
… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jan 12, 2026

Copy link
Copy Markdown

GH-143719 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 12, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2026
pythongh-143346: Fix calculation of the line width for wrapped Base64…
77fc4e5 
… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jan 12, 2026

Copy link
Copy Markdown

GH-143720 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 12, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 12, 2026
[3.13] gh-143346: Fix calculation of the line width for wrapped Base6…
8ec1083 
…4 in plistlib (GH-143347) (GH-143720)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 12, 2026
[3.14] gh-143346: Fix calculation of the line width for wrapped Base6…
6447fa3 
…4 in plistlib (GH-143347) (GH-143719)

It was incorrect in case of mixed tabs and spaces in indentation.
(cherry picked from commit 5f28aa2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
pythongh-143346: Fix calculation of the line width for wrapped Base64…
b7af241 
… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-143346: Fix calculation of the line width for wrapped Base64…
d386775 
… in plistlib (pythonGH-143347)

It was incorrect in case of mixed tabs and spaces in indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL