| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| .. versionadded:: 3.12 | ||
|
|
||
|
|
||
| .. c:macro:: PyUnstable_EXECUTABLE_KIND_SKIP |
There was a problem hiding this comment.
You used the branch from the other PR, please remove these changes here.
Sorry, something went wrong.
There was a problem hiding this comment.
I'm so sorry yes, fixing rn.
Sorry, something went wrong.
There was a problem hiding this comment.
I hope it's not an issue if i force push a new branch over this one to fix my error?
Sorry, something went wrong.
There was a problem hiding this comment.
In general, avoid them, in this case I think it is fine to remove the changes.
Sorry, something went wrong.
|
|
||
| .. c:function:: int PyUnstable_CopyPerfMapFile(const char *parent_filename) | ||
|
|
||
| Open the ``/tmp/perf-$pid.map`` file and append the content of *parent_filename* |
There was a problem hiding this comment.
This should note what happens on Windows where this obviously won't work.
Sorry, something went wrong.
There was a problem hiding this comment.
That's the case for all of these functions; the info should be in the beginning of the section.
This doesn't open the perf map file directly; it should use the same wording as PyUnstable_WritePerfMapEntry: “Will call :c:func:PyUnstable_PerfMapState_Init…”
Sorry, something went wrong.
There was a problem hiding this comment.
@encukou Would this wording be suitable then as a replacement for line 56 as:
"Calls :c:func:PyUnstable_PerfMapState_Init if the perf map is not yet
initialized, then append the content of parent_filename to the perf map."
Sorry, something went wrong.
There was a problem hiding this comment.
@encukou or @StanFromIreland Could you verify this one too?
Sorry, something went wrong.
There was a problem hiding this comment.
I'd say only “Append contents of the file named parent_filename to the perf map.” in the opening paragraph, and add the note about _Init later (like in WritePerfMapEntry docs).
Sorry, something went wrong.
| Open the ``/tmp/perf-$pid.map`` file and append the content of *parent_filename* | ||
| to it. | ||
|
|
||
| :param parent_filename: The name of the file to copy. |
There was a problem hiding this comment.
Please don't use these (:param *: & :return:), like above use sentences.
Sorry, something went wrong.
|
|
||
| .. c:function:: int PyUnstable_CopyPerfMapFile(const char *parent_filename) | ||
|
|
||
| Open the ``/tmp/perf-$pid.map`` file and append the content of *parent_filename* |
There was a problem hiding this comment.
I'd say only “Append contents of the file named parent_filename to the perf map.” in the opening paragraph, and add the note about _Init later (like in WritePerfMapEntry docs).
Sorry, something went wrong.
There was a problem hiding this comment.
Please update Tools/check-c-api-docs/ignored_c_api.txt as well.
Sorry, something went wrong.
|
Docs unrelated to test failure Tests / Windows (free-threading) / Build and test (arm64) (pull_request),Failing after 24m: testexternalinspection.testcacheperthreadisolation fails in free-threading |
Sorry, something went wrong.
|
@encukou @StanFromIreland |
Sorry, something went wrong.
There was a problem hiding this comment.
I asked some more questions. Could you go through the unresolved comments here?
Sorry, something went wrong.
| These unstable functions let you access and set perf map information | ||
| about the current frame from C code. |
There was a problem hiding this comment.
This doesn't make sense to me. What is the connection to the current frame?
Sorry, something went wrong.
There was a problem hiding this comment.
My bad, that text was completely out of place (and wrong). I'm deleting those lines entirely.
Sorry, something went wrong.
| Note: Appends the content of the parent frame to the current one in perf maps. | ||
| Just like in frameobject.h. |
There was a problem hiding this comment.
What function(s) is this note for? What is the connection to frameobject.h?
Sorry, something went wrong.
| Open the ``/tmp/perf-$pid.map`` file and append the content of *parent_filename* | ||
| to it. | ||
|
|
||
| This function is only available on platforms that support perf maps (currently |
There was a problem hiding this comment.
This is not accurate, the function is "available" on all platforms. But it should only be used on Linux. On Windows, it does nothing (it's not implemented).
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Documentation build overview2 files changed ± c-api/perfmaps.html ± whatsnew/changelog.html |
Sorry, something went wrong.
There was a problem hiding this comment.
I don't see any more blocking issues here -- let's get these documented!
If anyone disagrees with anything here, or otherwise want to make some change to the test, feel free to send a follow-up and tag me on it.
Sorry, something went wrong.
|
Thanks @Yashp002 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
|
Sorry, @Yashp002 and @ZeroIntensity, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 6453065db9ff31e3f737240030f8311d2b087851 3.14 |
Sorry, something went wrong.
|
GH-150849 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
|
Sorry, @Yashp002 and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 6453065db9ff31e3f737240030f8311d2b087851 3.13 |
Sorry, something went wrong.
|
Please don't forget about backports. |
Sorry, something went wrong.
|
GH-153994 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-153996 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
gh-141004: Document unstable perf map functions in ceval.h
This PR documents the PyUnstable_CopyPerfMapFile, PyUnstable_PerfTrampoline_CompileCode, and PyUnstable_PerfTrampoline_SetPersistAfterFork functions in Doc/c-api/perfmaps.rst.
📚 Documentation preview 📚: https://cpython-previews--143492.org.readthedocs.build/