FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-129824: Fix data race on runtime->gilstate.check_enabled by colesbury · Pull Request #143530 · python/cpython · GitHub

/ cpython Public

gh-129824: Fix data race on runtime->gilstate.check_enabled #143530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Jan 7, 2026
Conversation 1 Commits 2 Checks 46 Files changed
Merged

gh-129824: Fix data race on runtime->gilstate.check_enabled #143530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04003c
gh-129824: Fix data race on runtime->gilstate.check_enabled
colesbury Jan 7, 2026
bb7c984
Use atomic for read as well
colesbury Jan 7, 2026
File filter

Filter by extension

Filter by extension .c  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2435,7 +2435,7 @@ new_interpreter(PyThreadState **tstate_p,

/* Issue #10915, #15751: The GIL API doesn't work with multiple
interpreters: disable PyGILState_Check(). */
runtime->gilstate.check_enabled = 0;
_Py_atomic_store_int_relaxed(&runtime->gilstate.check_enabled, 0);
Comment thread
ZeroIntensity marked this conversation as resolved.

// XXX Might new_interpreter() have been called without the GIL held?
PyThreadState *save_tstate = _PyThreadState_GET();
Expand Down
2 changes: 1 addition & 1 deletion Python/pystate.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2832,7 +2832,7 @@ int
PyGILState_Check(void)
{
_PyRuntimeState *runtime = &_PyRuntime;
if (!runtime->gilstate.check_enabled) {
if (!_Py_atomic_load_int_relaxed(&runtime->gilstate.check_enabled)) {
return 1;
}

Expand Down
Loading
Back | FazBrowse Home | New Git URL